-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BigQuery] [GCS] Better ways to deal with google client mock #1117
Comments
Hello @ShihChun-H I want to work on this issue, Please assign me! |
Hi @naaa760, The issue has been assigned to you! Cheers! |
@ShihChun-H It seems this issue is still |
Hi @shubhamchasing , thanks for the reminder 🙏 |
Thank you for assigning me. I will solve this issue in a few hours! :) |
Hello @ShihChun-H |
Hi @naaa760 |
Thankyou! |
Hi @naaa760, I'm following up to check on any progress made regarding this issue. Could you please provide an update? Thanks 🙏 |
Hey @naaa760 how's it going? Just checking to see if you've had a new PR update since the last one? |
@kuroxx I would like to work on this. |
Hey @PrathameshTugaonkar thank you for your interest! @naaa760 since there has been no further activity, I will assign this issue to @PrathameshTugaonkar now, thanks! |
I am upto here on this - https://github.com/PrathameshTugaonkar/pipeline-backend/blob/main/pkg/component/data/bigquery/v0/main_test.go Could you check this, @kuroxx , to see if it's the expected outcome? I will add the test cases accordingly? |
Hi @PrathameshTugaonkar , For Or, you can take a look on json operator test code as an example. The main problem in this ticket is - the SDK provided by Google does not design Now, I have 2 possible solution.
I think both ways are ok for me. 1. is easier. 2. is more solid in the perspective of integration test. Ideally, we would like to do 2. But, if it is too difficult, 1. is also acceptable. |
Hey @PrathameshTugaonkar how's this going? I wanted to let you know that we will need a PR by the end of this week (8th Nov) since we are closing this event. Please submit:
to ensure your contribution is counted! Alternatively, if you cannot complete this within the time frame but would still like to contribute, you are more than welcome to but please note it would not be within the scope of Hacktoberfest 2024. Thank you and look forward to your contribution! ✨ |
Issue Description
Current State
Why We Want to Change?
Proposed Change
Rules for the Component Hackathon
Component Contribution Guideline | BigQuery Documentation | GCS Documentation | Official Go Tutorial
The text was updated successfully, but these errors were encountered: