Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallets): reuse session_id across multiple TrezorSigner #9388

Open
joshieDo opened this issue Nov 23, 2024 · 0 comments
Open

feat(wallets): reuse session_id across multiple TrezorSigner #9388

joshieDo opened this issue Nov 23, 2024 · 0 comments
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers

Comments

@joshieDo
Copy link
Collaborator

joshieDo commented Nov 23, 2024 •
edited
Loading

Component

Forge

Describe the feature you would like

foundry/crates/wallets/src/multi_wallet.rs

Lines 369 to 375 in 398ef4a

pub async fn trezors(&self) -> Result<Option<Vec<WalletSigner>>> {
if self.trezor {
create_hw_wallets!(self, utils::create_trezor_signer, wallets);
return Ok(Some(wallets));
}
Ok(None)
}

Currently, every new instance of TrezorSigner is created with their own session_id. If a passphrase is enabled on the device, it means requesting it for every mnemonic index.

Ideally, each TrezorSigner reuses the first created session_id.

Additional context

No response
@joshieDo joshieDo added the good first issue Good for newcomers label Nov 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 23, 2024
@joshieDo joshieDo added C-forge Command: forge Cmd-forge-script Command: forge script labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshieDo