Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate rules in the miss_hit config seem to be allowed #242

Open
Remi-Gau opened this issue Nov 15, 2021 · 2 comments
Open

duplicate rules in the miss_hit config seem to be allowed #242

Remi-Gau opened this issue Nov 15, 2021 · 2 comments
Labels
component: core Affects the core infrastructure

Comments

@Remi-Gau
Copy link
Contributor

MISS_HIT Component affected

  • Style checker

Your MATLAB/Octave environment

  • Linux Ubuntu 18-04
  • python 3.8
  • matlab

Describe the bug

By chance I ended up having this in my config and it did not throw a warning or an error. I am not sure what should be the intended behavior, there.

regex_function_name: "[a-zA-Z0-9]+(_[a-zA-Z0-9]+)*"
regex_function_name: "[a-z]+(_[a-z]+)*"
@florianschanda
Copy link
Owner

This is by design, since you can overwrite config items with config files further down the directory tree.

That said, I will implement a warning here since there is no real use case that I can think of to have something specified twice in the same file.

@florianschanda florianschanda added the component: core Affects the core infrastructure label Nov 16, 2021
@Remi-Gau
Copy link
Contributor Author

This is by design, since you can overwrite config items with config files further down the directory tree.

Ah yes I see. Thanks for the clarification. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Affects the core infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florianschanda @Remi-Gau