Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batchCreate. #2947

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Support batchCreate. #2947

merged 4 commits into from
Dec 17, 2020

Conversation

yuchenshi
Copy link
Member

Description

This adds support for batchCreate, with a few corner cases intentionally omitted for sanity. One step closer to import/export!

Scenarios Tested

Comprehensive spec test added.

Sample Commands

@google-cla google-cla bot added the cla: yes Manual indication that this has passed CLA. label Dec 17, 2020
samtstern
samtstern approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@samtstern samtstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you resolve your own TODOs

@yuchenshi yuchenshi merged commit b24b972 into master Dec 17, 2020
@yuchenshi yuchenshi deleted the ys/auth-emu-batchCreate branch December 17, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern samtstern approved these changes

@sam-gc sam-gc Awaiting requested review from sam-gc

Assignees

@samtstern samtstern

Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuchenshi @samtstern