Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-App Messaging's test message does not include appData in response (and also not in InAppMessagingDisplayMessage ) #9126

Open
fumito-ito opened this issue Dec 22, 2021 · 5 comments · Fixed by #9134
Open

In-App Messaging's test message does not include appData in response (and also not in InAppMessagingDisplayMessage ) #9126

fumito-ito opened this issue Dec 22, 2021 · 5 comments · Fixed by #9134
Assignees
@zwu52
Labels
api: inappmessaging Firebase In App Messaging

Comments

@fumito-ito
Copy link
Contributor

fumito-ito commented Dec 22, 2021 •
edited
Loading

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 13.2.1
  • Firebase SDK version: 8.4.0
  • Installation method: Swift Package Manager
  • Firebase Component: In-App Messaging
  • Target platform(s): iOS

[REQUIRED] Step 2: Describe the problem

In-App Messaging' message has appData property. But it looks always nil for test message.

Steps to reproduce:

  1. Make an App to receive In-App Messaging
  2. Create and send Test message from Firebase Console
  3. Set a break point at displayMessage(:displayDelegate:) in 1.'s App and run the App in Debug mode
  4. See messageForDisplay.appData in debug console. It shows nil.

Relevant Code:

There are two causes of this problem.

1. FIRIAMFetchResponseParser always ignores appData for test message

firebase-ios-sdk/FirebaseInAppMessaging/Sources/Data/FIRIAMFetchResponseParser.m

Lines 357 to 367 in d28849c

if (isTestMessage) {
return [[FIRIAMMessageDefinition alloc] initTestMessageWithRenderData:renderData
experimentPayload:experimentPayload];
} else {
return [[FIRIAMMessageDefinition alloc] initWithRenderData:renderData
startTime:startTimeInSeconds
endTime:endTimeInSeconds
triggerDefinition:triggersDefinition
appData:dataBundle
experimentPayload:experimentPayload
isTestMessage:NO];

In this code, FIRIAMFetchResponseParser looks ignore appData for test message.

2. In-App Messaging's response does not contain appData property for test message.

firebase-ios-sdk/FirebaseInAppMessaging/Sources/Flows/FIRIAMMsgFetcherUsingRestful.m

Lines 171 to 173 in 480178b

NSDictionary *responseDict = [NSJSONSerialization JSONObjectWithData:data
options:kNilOptions
error:&errorJson];

I found that appData also does not be included in responseDict for test message. It looks happened every time for test message.
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@fumito-ito fumito-ito changed the title In-App Messaging's test message does not include appData in response (and also not in FIRInAppMessaging) In-App Messaging's test message does not include appData in response (and also not in InAppMessagingDisplayMessage ) Dec 22, 2021
@rizafran rizafran added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Dec 22, 2021
@fumito-ito fumito-ito mentioned this issue Dec 23, 2021
Merged
@fumito-ito
Copy link
Contributor Author

@zwu52 Any updates on this ? In my use case, I detect custom message type by appData. But now, I cannot do it in test case because of this bug.

@zwu52
Copy link
Member

zwu52 commented Jan 21, 2022 •
edited
Loading

Hi @fumito-ito ,
apologies for missing the thread. Thanks for reporting & coming up with the fix. LGTM. I have pinged the owner for a final quick review & approval.

@eldhosembabu
Copy link
Contributor

The SDK fix is merged, but it needs a fix from backend side as well to push this data to the client device.

@eldhosembabu eldhosembabu reopened this Jan 26, 2022
@eldhosembabu
Copy link
Contributor

filed an internal bug to track the backend issue : b/216496087

@fumito-ito fumito-ito mentioned this issue May 25, 2022
Closed
@jordanbisato jordanbisato mentioned this issue Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zwu52 zwu52

Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pass appData for In-App Messaging's test message fumito-ito/firebase-ios-sdk
5 participants
@eldhosembabu @zwu52 @google-oss-bot @fumito-ito @rizafran