-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Distribution FIRAppDistributionRelease.releaseNotes may be null, documented as non-null #8602
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
For ecosystem comparison, I know firebase-android-sdk hasn't released app distribution yet, but they are working hard on it, and they are marked as nullable: |
… nullable matches upstream reality / future state firebase/firebase-ios-sdk#8602 related #5667
… nullable matches upstream reality / future state firebase/firebase-ios-sdk#8602 related #5667
This may be addressable earlier, but I'll mark for the next major release to review when we do a thorough nullability review at that point. |
Confirming with the App Distro team that this is intentional and not a backend bug or anything - will fix afterwards. |
These were unintentionally marked as non-null, but should be nullable. Fixes #8602
These were unintentionally marked as non-null, but should be nullable. Fixes #8602
Fixed in the Firebase 9 branch which will be merged soon. Closing now, thanks for the report and sorry for the troubles! |
These were unintentionally marked as non-null, but should be nullable. Fixes #8602
Step 0: Are you in the right place?
file a Github issue.
with the
firebase
tag.google group.
of the above categories, reach out to
Firebase Support.
this repository, please delete this section.
[REQUIRED] Step 1: Describe your environment
CocoaPods
[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
The documentation for the releaseNotes property on FIRAppDistributionRelease indicates it is non-null https://firebase.google.com/docs/reference/ios/firebaseappdistribution/api/reference/Classes/FIRAppDistributionRelease#releasenotes
However, in practice the property may be null? invertase/react-native-firebase#5667
Now, it may well be this is my incorrect interpretation of what non-null means in objective-c as a modifier on a property, perhaps what it means is that you cannot attempt to set it to null, but if accessed (without ever being set) it is potentially null.
If so, apologies for the noise, please close, and I've learned something (and thank you)
But if this is an issue it should be fixed either in documentation or code or where ever the data is initiall provided I guess
Relevant Code:
Crash report in linked react-native-firebase issue, but:
If you do that, the releaseNotes property will potentially be nil
The text was updated successfully, but these errors were encountered: