Bump Promises dependency #8365
Merged
Bump Promises dependency #8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Jul 9, 2021
|
Test the podspec changes first, to avoid the need to prematurely tag the GoogleUtilities and GTM repos. The podspecs should be updated. Bumping the GoogleUtilities minimum dependency is fine, but not required since the firebase-ios-sdk SPM should still work with 7.4.x .... |
|
@paulb777 So with the specs bumped and CI green, GDT and GULs are good to publish, correct? |
|
Let's wait for a clean nightly run before publishing GDT and GoogleUtilities. This is good to merge after adding a CHANGELOG update for 8.4.0 |
paulb777
approved these changes
Jul 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan is to:
Fixes #8334