-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: allow authDomain override in plist #7553
Comments
Yes, please. |
Hi team, can we get this prioritised please? As per this notification from Google:
However all feasible options require setting the |
I opened a ticket for Android as well. |
Thanks for filing this! The best practice needs to be applied only for web applications that use the |
@prameshj thats great! Can you please elaborate why and explain what the best practice solution is for using a custom domain on mobile clients should then be? |
This guide applies to web applications that use redirect to login. The clients of this web app can be mobile clients (using a mobile browser) or web clients. The best practice(of setting authDomain or any other option) should be implemented in the web application. This is needed because in redirect flow we 1) start at the app domain (call it domain1), 2) redirect to oauth helper code (in /__/auth/handler, call this domain 3), store some state in session storage of domain 2 3) redirect back to the app and open iframe to domain 2 and access session storage. This cross origin storage access is disallowed in some browser policies, so all the best practices are towards making sure domain1 and domain2 are the same origin. On mobile apps, a similar IDP sign in redirects to the browser, but there is no cross-origin storage access. Hence there is no action needed for mobile apps. |
Similar to what I mentioned in the Android ticket, I guess our reasoning is not that it doesn't work, but that we would like to show our configured custom domain to the end user instead of the default Is there a way to do this? |
Hi @skion, we currently do not support custom domain on mobile. We have put this feature request on our radar, but we are unable to promise a timeline right now. |
just a FYI - we dumped firebase and went with auth0; the lack of feature parity and prioritization for things like this was the motivator for moving off firebase auth. |
At least indicate in the official documentation that using a custom domain leads to the breakdown of any oauth2 authorization in native applications (tested on github, apple, facebook). |
Allowing the authDomain to be set in mobile is a must to prevent brute force attacks using the public key. This would allow us to host a proxy behind firewalls and WAF's that can mitigate such brute force attacks from hitting the google auth api's directly. |
[READ] Guidelines
Feature proposal
Allow authDomain to be set in plist so custom domain can be used in the oauth flow.
This can already be done for web once you setup your custom domain.
The text was updated successfully, but these errors were encountered: