177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087

nneverlander · 2020-12-03T14:38:47Z

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.2
Firebase SDK version: 6.31.1
Installation method: CocoaPods (select one)
Firebase Component: DynamicLinks

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

Using a custom sub domain for dynamic links (like links.example.com) doesn't work. The piece of code below from the firebase library is checking for a trailing '/' at the end of the host. See the line:

if (urlStr.length > domainURIPrefixStr.length + 1 && ([urlStr characterAtIndex:domainURIPrefixStr.length] == '/'))

Why is this check necessary? This check will only allow custom domains that have a trailing '/'

Relevant Code:

BOOL FIRDLIsURLForWhiteListedCustomDomain(NSURL *_Nullable URL) {
  BOOL customDomainMatchFound = false;
  for (NSURL *allowedCustomDomain in FIRDLCustomDomains) {
    // All custom domain host names should match at a minimum.
    if ([allowedCustomDomain.host isEqualToString:URL.host]) {
      NSString *urlStr = URL.absoluteString;
      NSString *domainURIPrefixStr = allowedCustomDomain.absoluteString;

      // Next, do a string compare to check if entire domainURIPrefix matches as well.
      if (([URL.absoluteString rangeOfString:allowedCustomDomain.absoluteString
                                     options:NSCaseInsensitiveSearch | NSAnchoredSearch]
               .location) == 0) {
        // The (short) URL needs to be longer than the domainURIPrefix, it's first character after
        // the domainURIPrefix needs to be '/' and should be followed by at-least one more
        // character.
        if (urlStr.length > domainURIPrefixStr.length + 1 &&
            ([urlStr characterAtIndex:domainURIPrefixStr.length] == '/')) {
          // Check if there are any more '/' after the first '/'trailing the
          // domainURIPrefix. This does not apply to unique match links copied from the clipboard.
          // The clipboard links will have '?link=' after the domainURIPrefix.
          NSString *urlWithoutDomainURIPrefix =
              [urlStr substringFromIndex:domainURIPrefixStr.length + 1];
          if ([urlWithoutDomainURIPrefix rangeOfString:@"/"].location == NSNotFound ||
              [urlWithoutDomainURIPrefix rangeOfString:@"?link="].location != NSNotFound) {
            customDomainMatchFound = true;
            break;
          }
        }
      }
    }
  }
  return customDomainMatchFound;
}

The text was updated successfully, but these errors were encountered:

google-oss-bot · 2020-12-03T14:38:48Z

I found a few problems with this issue:

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
This issue does not seem to follow the issue template. Make sure you provide all the required information.

nneverlander · 2020-12-03T14:43:00Z

I am using dynamic links to send password reset emails with a custom domain. The generated link in the email looks like this:

https://links.example.com?link=https://example.com/__/auth/action?apiKey%abc%26mode%3DresetPassword%26oobCode%3D9OsQMmdKAPo6J7RRO2bAUMYTV3TEzReToKJpSy-xSWcAAAF2KLCPsw%26continueUrl%3Dhttps://example.com/__/auth/action%26lang%3Den&ibi=com.example.ios&ifl=https://example.com/__/auth/action?apiKey%abc%26mode%3DresetPassword%26oobCode%3D9OsQMmdKAPo6J7RRO2bAUMYTV3TEzReToKJpSy-xSWcAAAF2KLCPsw%26continueUrl%3Dhttps://example.com/__/auth/action%26lang%3Den

The link doesn't have a trailing '/' causing the SDK to fail the customDomainMatchFound check.

Kaspik · 2020-12-04T12:02:41Z

I believe the same applies to Google Analytics logging automatically query params.

Universal link https://www.domain.com/someLink?utm_source=email&utm_medium=email&utm_campaign=campaign
doesn't work where
Universal link https://www.domain.com/someLink/?utm_source=email&utm_medium=email&utm_campaign=campaign
does work

@paulb777 Is this intended? If not, should I open another issue, or is it related?

nneverlander · 2020-12-04T22:13:04Z

I am curious about this check for the presence of trailing ‘/‘. Can someone explain why this check is done?

On Fri, Dec 4, 2020 at 5:32 PM Jakub Kašpar ***@***.***> wrote: I believe the same applies to Google Analytics logging automatically query params. Universal link https://www.domain.com/someLink?utm_source=email&utm_medium=email&utm_campaign=campaign doesn't work where Universal link https://www.domain.com/someLink/?utm_source=email&utm_medium=email&utm_campaign=campaign does work @paulb777 <https://github.com/paulb777> Is this intended? If not, should I open another issue, or is it related? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7087 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAY5UTTU6P7R6AGFF3PEEYTSTDFXBANCNFSM4UMCEJ2Q> .

-- Thanks, Adi Email: [email protected]

eldhosembabu · 2021-01-13T23:51:28Z

Internal bug created and will be prioritizing and looking into it: b/177469304

reimertz · 2021-02-21T20:52:51Z

Oh man, I've spent days trying to figure out why email sign in links worked fine in Apple Mail but no other email client.

Eventually went deep and logged the incoming url and somehow slash was missing even thought they weren't when manually copied. I assume iOS applies missing slash when copied?.

Anyhow, It's been 2 months since this was filed and is currently breaking email passwordless registrations for iOS users.
So please please, prioritize this some more! <3

reimertz · 2021-02-21T20:56:40Z

For me to get around this issue, I added a temp hack to handleUniversalLink:

- (BOOL)handleUniversalLink:(NSURL *)universalLinkURL
                 completion:(FIRDynamicLinkUniversalLinkHandler)completion {
                   
    NSString *slashedString = [universalLinkURL.absoluteString stringByReplacingOccurrencesOfString:@"ENTER_YOUR_CUSTOM_DOMAIN_HERE?link=" 
      withString:@"ENTER_YOUR_CUSTOM_DOMAIN_HERE/?link="];
    NSURL *fixedUniversalLinkURL = [NSURL URLWithString:slashedString];

  if ([self matchesShortLinkFormat:fixedUniversalLinkURL]) {
    __weak __typeof__(self) weakSelf = self;
    [self resolveShortLink:fixedUniversalLinkURL
                completion:^(NSURL *url, NSError *error) {
                  __typeof__(self) strongSelf = weakSelf;
                  if (strongSelf) {
                    FIRDynamicLink *dynamicLink = [strongSelf dynamicLinkFromCustomSchemeURL:url];
                    dispatch_async(dispatch_get_main_queue(), ^{
                      completion(dynamicLink, error);
                    });
                  } else {
                    completion(nil, nil);
                  }
                }];
    return YES;
  } else {
    [self dynamicLinkFromUniversalLinkURL:fixedUniversalLinkURL completion:completion];
    BOOL canHandleUniversalLink =
        [self canParseUniversalLinkURL:fixedUniversalLinkURL] && fixedUniversalLinkURL.query.length > 0 &&
        FIRDLDictionaryFromQuery(universalLinkURL.query)[kFIRDLParameterLink];
    return canHandleUniversalLink;
  }
}
    ```

rkbhochalya · 2021-03-03T09:29:29Z

I just wanted to add that sign-in links work from other email apps on iOS if a Google-provided domain (e.g. projectname.page.link) is used to generate sign-in links. This can be used as a workaround in some cases.

I have a working example react-native app with a Google-provided domain here.

jonasN5 · 2021-04-10T20:15:06Z

Can you please fix this???? I've just lost a whole day until I debugged the problem myself and searched for this open issue. This completely blocks custom domains...

allanwolski · 2021-04-13T01:11:15Z

I also spent a day trying to find the problem.

https://stackoverflow.com/questions/61393682/firebase-authentication-link-not-working-missing-trailing-slash

kaciula · 2021-07-02T15:13:18Z

@reimertz Hi. I'm having the same problem and I would like to apply your workaround. I've created a local copy of the FirebaseDynamicLinks pod directory, I've modified the handleUniversalLink method and I'm pointing to this local pod inside the main Podfile. Not sure how to write the podspec for the local pod however.

Can you help with some basic steps of using a custom local pod of FirebaseDynamicLinks?

(I'm a Flutter developer so I am not very familiar with how pods work on ios.)

ygotthilf · 2021-07-28T07:57:17Z

I've also spent the whole day trying to figure out why deep link is not triggered by my app from GMail iOS App.

movvam · 2021-08-31T02:35:20Z

exactly same^

eldhosembabu · 2021-09-09T18:20:13Z

This seems like purposefully introduced in PR: #2563

[FDL] Refactoring and fixing url validation Refactored the existing code to use Regex to validate FDL URL formats. Added checks to make sure the 'link' query param is having an http/https prefix input. == This is going to be breaking the existing SDK's unintended behavior to support links with non http/https content. The existing SDK was constructing the Dynamic link even though the backend response to resolve the link is not successful. Added support for URL(s) with Query string starting with '?' alone. Previously it was supporting '/?' formats only. This fixes 177469304: Firebase dynamic links with custom domain will only work if the custom domain has a trailing '/' #7087 Added more test cases to be in sync with FDL backend validation. Removed invalid test inputs and corrected few test cases to make the input in proper format.

google-oss-bot added the needs-triage label Dec 3, 2020

paulb777 added api: dynamiclinks and removed needs-triage labels Dec 3, 2020

paulb777 assigned eldhosembabu Dec 4, 2020

eldhosembabu changed the title ~~Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/'~~ 177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' Jan 13, 2021

rkbhochalya mentioned this issue Mar 3, 2021

[🐛] 🔥 Firebase sign in link not working from Gmail app on iOS when using a custom domain for dynamic links invertase/react-native-firebase#4976

Closed

10 tasks

tmldsousa mentioned this issue Jun 22, 2021

Email Link Authentication produces invalid URL / error 500 when using dynamic links / mobile authentication firebase/firebase-js-sdk#5054

Closed

eldhosembabu mentioned this issue Sep 20, 2021

[FDL] Refactoring and fixing url validation #8672

Merged

eldhosembabu closed this as completed in #8672 Sep 22, 2021

firebase locked and limited conversation to collaborators Oct 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087

177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087

nneverlander commented Dec 3, 2020 •

edited

Loading

google-oss-bot commented Dec 3, 2020

nneverlander commented Dec 3, 2020 •

edited

Loading

Kaspik commented Dec 4, 2020

nneverlander commented Dec 4, 2020 via email

eldhosembabu commented Jan 13, 2021

reimertz commented Feb 21, 2021

reimertz commented Feb 21, 2021 •

edited

Loading

rkbhochalya commented Mar 3, 2021

jonasN5 commented Apr 10, 2021

allanwolski commented Apr 13, 2021 •

edited

Loading

kaciula commented Jul 2, 2021

ygotthilf commented Jul 28, 2021 •

edited

Loading

movvam commented Aug 31, 2021

eldhosembabu commented Sep 9, 2021

177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087

177469304: Firebase dynamic links with custom domain will only work if the custom domai has a trailing '/' #7087

Comments

nneverlander commented Dec 3, 2020 • edited Loading

[REQUIRED] Step 1: Describe your environment

[REQUIRED] Step 2: Describe the problem

Steps to reproduce:

Relevant Code:

google-oss-bot commented Dec 3, 2020

nneverlander commented Dec 3, 2020 • edited Loading

Kaspik commented Dec 4, 2020

nneverlander commented Dec 4, 2020 via email

eldhosembabu commented Jan 13, 2021

reimertz commented Feb 21, 2021

reimertz commented Feb 21, 2021 • edited Loading

rkbhochalya commented Mar 3, 2021

jonasN5 commented Apr 10, 2021

allanwolski commented Apr 13, 2021 • edited Loading

kaciula commented Jul 2, 2021

ygotthilf commented Jul 28, 2021 • edited Loading

movvam commented Aug 31, 2021

eldhosembabu commented Sep 9, 2021

nneverlander commented Dec 3, 2020 •

edited

Loading

nneverlander commented Dec 3, 2020 •

edited

Loading

reimertz commented Feb 21, 2021 •

edited

Loading

allanwolski commented Apr 13, 2021 •

edited

Loading

ygotthilf commented Jul 28, 2021 •

edited

Loading