Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using CocoaPods private headers #6572

Merged
merged 7 commits into from
Oct 2, 2020
Merged

Stop using CocoaPods private headers #6572

merged 7 commits into from
Oct 2, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 25, 2020 •
edited
Loading

Stop using CocoaPods private headers to be more consistent with Swift Package Manager.

Instead internal API's between repo pods should be referenced with repo-relative imports.

FirebaseCore Private's are kept for now because of internal non-Firebase client usage via CocoaPods (Flutter for example)

@paulb777 paulb777 marked this pull request as draft September 25, 2020 23:11
@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 1, 2020
@paulb777 paulb777 changed the base branch from firebase7-main to master October 2, 2020 00:09
@paulb777 paulb777 added cla: yes and removed cla: no labels Oct 2, 2020
@firebase firebase deleted a comment from google-cla bot Oct 2, 2020
@paulb777 paulb777 marked this pull request as ready for review October 2, 2020 00:14
@firebase firebase deleted a comment from google-oss-bot Oct 2, 2020
ryanwilson
ryanwilson reviewed Oct 2, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, but we should keep Core's private headers to avoid breaking any downstream dependencies like Flutter and RN depending on it.

@paulb777 paulb777 merged commit 12c9e3f into master Oct 2, 2020
@paulb777 paulb777 deleted the pb-rm-cp-private branch October 2, 2020 16:11
@firebase firebase locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: core api: remoteconfig cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulb777 @ryanwilson @googlebot @google-oss-bot