Move FIRSecureStorage to GoogleUtilities #5329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 9, 2020
| @@ -22,6 +22,8 @@ | |||
| #import "FBLPromises.h" | |||
| #endif | |||
|
|
|||
| #import <GoogleUtilities/GULKeychainStorage.h> | |||
There was a problem hiding this comment.
Nit: alphabetically below FirebaseCore
| @@ -34,6 +34,8 @@ other Google CocoaPods. They're not intended for direct public usage. | |||
| es.source_files = 'GoogleUtilities/Environment/**/*.[mh]' | |||
| es.public_header_files = 'GoogleUtilities/Environment/**/*.h' | |||
| es.private_header_files = 'GoogleUtilities/Environment/**/*.h' | |||
|
|
|||
| es.dependency 'PromisesObjC', '~> 1.2' | |||
There was a problem hiding this comment.
Separate from this review - but are we comfortable allowing minor version updates of Promises. It might be safer to lock to patch version updates ...
charlotteliang
approved these changes
Apr 9, 2020
|
|
||
| - (instancetype)init { | ||
| NSCache *cache = [[NSCache alloc] init]; | ||
| // Cache up to 5 installations. | ||
| cache.countLimit = 5; | ||
| return [self initWithService:@"com.firebase.FIRInstallations.installations" cache:cache]; | ||
| return [self initWithService:@"com.gul.KeychainStorage" cache:cache]; |
There was a problem hiding this comment.
Seems like the location has changed, how do we ensure the old keychain data is not wiped when update to this version?
And do we care about backward compatibility?
There was a problem hiding this comment.
Good catch! Let me make sure the service name is always set by client, so Installations will keep using the same service as before.
Merged
ryanwilson
pushed a commit
that referenced
this pull request
Apr 24, 2020
* FIRSecureStorage -> GULKeychainStorage: renamed and moved to GoogleUtilities * FIS updated to GULKeychainStorage * Run ./scripts/style.sh * Headers order * GULKeychainUtils API docs * GULKeychainStorage: require Keychain service name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIRSecureStoragemoved to GoogleUtilities and renamed toGULKeychainStorageGULKeychainStorage