Crashlytics resolve symbol collisions with old SDK #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samedson
changed the title
paulb777
approved these changes
Jan 28, 2020
SymbolCollisionTest/Podfile
Outdated
| @@ -12,7 +12,7 @@ target 'SymbolCollisionTest' do | |||
| pod 'FirebaseAnalytics' | |||
| pod 'FirebaseAuth', :path => '../' | |||
| pod 'FirebaseCore', :path => '../' | |||
| # pod 'FirebaseCrashlytics', :path => '../' #4746 | |||
| pod 'FirebaseCrashlytics', :path => '../' #4746 | |||
There was a problem hiding this comment.
delete issue number comment.
Note the SymbolCollisionTest only runs on the travis cron. To test locally in a PR, see https://github.com/firebase/firebase-ios-sdk/tree/master/SymbolCollisionTest#run-locally
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old and New SDK are not compatible in the same app, but symbol collisions are not a great way to discover that. Going to add a warning when both SDKs are included.