Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InAppMessaging] Banner message display overlaps status bar on iPad Pro 11" #4714

Closed
xaphod opened this issue Jan 21, 2020 · 3 comments · Fixed by #5100
Closed

[InAppMessaging] Banner message display overlaps status bar on iPad Pro 11" #4714

xaphod opened this issue Jan 21, 2020 · 3 comments · Fixed by #5100
Assignees
@christibbs
Labels
api: inappmessaging Firebase In App Messaging
Milestone
6.21.0 - M67

Comments

@xaphod
Copy link

xaphod commented Jan 21, 2020

[READ] Step 1: Are you in the right place?

According to @christibbs yup

[REQUIRED] Step 2: Describe your environment

  • Xcode version: 11.3.1
  • Firebase SDK version: 6.15.0
  • Firebase Component: InAppMessaging
  • Component version: 0.16.0, InAppMessagingDisplay is 0.15.5

[REQUIRED] Step 3: Describe the problem

Banner message overlaps with status bar text, looks awful. See photo:

72654704-b4211f00-395e-11ea-8d85-caa7e1464adb

Steps to reproduce:

Display a banner style message on iPad Pro 11" (2018 model, the only one I think), running iOS 13.3
@google-oss-bot

This comment has been minimized.

Sign in to view
@xaphod xaphod mentioned this issue Jan 21, 2020
Closed
@paulb777 paulb777 added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Jan 21, 2020
@rizafran
Copy link
Contributor

Thanks for reporting the issue, @xaphod. I was able to replicate this using the sample quickstart. I filed this internally (b/148132944) and I'll let you know once I have an update.

@christibbs
Copy link
Contributor

Sorry for the delay, this will be fixed in an upcoming release. Will close when code is complete.

@christibbs christibbs mentioned this issue Mar 13, 2020
Merged
@christibbs christibbs added this to the 6.21.0 - M67 milestone Mar 14, 2020
@firebase firebase locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christibbs christibbs

Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Milestone
6.21.0 - M67
Development

Successfully merging a pull request may close this issue.

In banner view, pin top elements to the bottom of the status bar firebase/firebase-ios-sdk
5 participants
@paulb777 @xaphod @google-oss-bot @christibbs @rizafran