Support the RTDB emulator #3491
Conversation
schmidt-sebastian
force-pushed
the
mrschmidt/emulator
branch
from
2e9a8b4 to
66d5dd8
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/emulator
branch
from
66d5dd8 to
e5f30d6
Compare
|
We still need people to be able to specify the database name (for example to test triggers), so just accepting |
Firebase/Database/CHANGELOG.md
Outdated
| to the emulator, specify "http://<emulator_host>/" as your Database URL | ||
| (via `Database.database(url:)`). | ||
| If you refer to your emulator host by IP rather than by domain name, you may | ||
| also need to specify a namespace ("http://<emulator_host>/?ns=<project_id>"). |
There was a problem hiding this comment.
"namespace" => " project id" ? Or some other implementation-independent term.
| bool secure; | ||
|
|
||
| if (urlComponents.port != nil) { | ||
| secure = [urlComponents.scheme isEqualToString:@"https"]; |
There was a problem hiding this comment.
FWIW, on web I think we support wss:// URLs (which IIRC disables long-polling). I wonder if we should try for some consistency.
There was a problem hiding this comment.
I added support for "wss".
| secure = [urlComponents.scheme isEqualToString:@"https"]; | ||
| host = [host stringByAppendingFormat:@":%@", urlComponents.port]; | ||
| } else if ( [urlComponents.host isEqualToString:@"localhost"]) { | ||
| secure = NO; |
There was a problem hiding this comment.
Why do we do this? Did the old code do this?
There was a problem hiding this comment.
Seems like this is not winning anyone over, so I dropped this from the iOS port (will drop the special casing for Android too).
| } | ||
|
|
||
|
|
||
| NSString* pathString = [self decodePath:[NSString stringWithFormat:@"/%@", originalPathString]]; | ||
| FPath * path = [[FPath alloc] initWith:pathString]; |
There was a problem hiding this comment.
seems like there are extra spaces here? Why does clang-format not fix that?
There was a problem hiding this comment.
Fixed manually. Seems like we are excluded from the formatter (but it still takes 10 seconds to run). I'll get the formatting enabled for RTDB in a follow up.
There was a problem hiding this comment.
This source is now clang-formatted.
Firebase/Database/CHANGELOG.md
Outdated
| to the emulator, specify "http://<emulator_host>/" as your Database URL | ||
| (via `Database.database(url:)`). | ||
| If you refer to your emulator host by IP rather than by domain name, you may | ||
| also need to specify a namespace ("http://<emulator_host>/?ns=<project_id>"). |
| bool secure; | ||
|
|
||
| if (urlComponents.port != nil) { | ||
| secure = [urlComponents.scheme isEqualToString:@"https"]; |
There was a problem hiding this comment.
I added support for "wss".
| secure = [urlComponents.scheme isEqualToString:@"https"]; | ||
| host = [host stringByAppendingFormat:@":%@", urlComponents.port]; | ||
| } else if ( [urlComponents.host isEqualToString:@"localhost"]) { | ||
| secure = NO; |
There was a problem hiding this comment.
Seems like this is not winning anyone over, so I dropped this from the iOS port (will drop the special casing for Android too).
| } | ||
|
|
||
|
|
||
| NSString* pathString = [self decodePath:[NSString stringWithFormat:@"/%@", originalPathString]]; | ||
| FPath * path = [[FPath alloc] initWith:pathString]; |
There was a problem hiding this comment.
Fixed manually. Seems like we are excluded from the formatter (but it still takes 10 seconds to run). I'll get the formatting enabled for RTDB in a follow up.
This adds support for the emulator and also for the "ns" query param.\
Technically, iOS doesn't need the "ns" query param since "localhost" is a valid RTDB namespace name and we could just use "localhost" as the namespace. But since I just went all out on Android (firebase/firebase-android-sdk#680), I decided to make this PR equally awesome. Plus who doesn't like some good URL decoding/encoding mess.