Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call getToken before subscription/unsubscription #3438

Merged
merged 6 commits into from
Jul 30, 2019
Merged

Always call getToken before subscription/unsubscription #3438

merged 6 commits into from
Jul 30, 2019

Conversation

charlotteliang
Copy link
Contributor

No description provided.

paulb777
paulb777 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the swift file change is reverted.

maksymmalyhin
maksymmalyhin approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Example/Messaging/Tests/FIRMessagingServiceTest.m Show resolved Hide resolved
Example/Messaging/Tests/FIRMessagingServiceTest.m Show resolved Hide resolved
Example/Messaging/Tests/FIRMessagingServiceTest.m Show resolved Hide resolved
maksymmalyhin
maksymmalyhin approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlotteliang charlotteliang merged commit 5c26ae4 into master Jul 30, 2019
@charlotteliang charlotteliang deleted the fcm-topic branch July 30, 2019 20:59
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christibbs christibbs christibbs left review comments

@wilhuff wilhuff wilhuff left review comments

@alexames alexames alexames left review comments

@morganchen12 morganchen12 morganchen12 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@charlotteliang @paulb777 @alexames @maksymmalyhin @morganchen12 @wilhuff @christibbs @googlebot