-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase XCFrameworks are not codesigned #12238
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
👍 I saw the privacy manifest work but I didn't see anything about the signature requirement. Thanks! |
hello, any ETA when this codesigning will be included? |
Hi @hendri-voodoo, I do not have an eta to share, but the signing infra is taking longer to set up and may come after the release containing privacy manifests. We will keep this bug updated when we have an eta to share. #11490 (comment) |
@ncooke3 noted. When is your next release cycle? |
Hi Any updates on signing? |
1 similar comment
Hi Any updates on signing? |
Hi is it possible to provide an ETA for release with code signing? |
Hi Team any timeline where we can look for this ? |
The target window is between late March and mid April and we're working to do it as soon as we can in that timespan. |
Hi everyone, we are still actively working on this, but I do have an update to share. In the upcoming Firebase 10.23.0 (tentatively scheduled for next week), Firestore's SwiftPM binary distribution will feature signed XCFrameworks. In practice, this will apply to all of the XCFrameworks that are used when using Firestore with SPM: Support for signed artifacts in other binary distributions will follow in future releases. |
Hi! I saw release 10.23.0 signed xcframeworks for Firestore. Sorry to ask but what is the ETA for the other packages? |
We're working towards providing signed xcframeworks in the next minor release, due out the week of April 8th |
Will the non-Firebase xcframeworks such as GoogleSignIn be also a target of the next release? |
@shingt, yes. Every framework in the Firebase.zip will have a code signature. |
Which release will have this fix? 10.23.2? |
10.24.0, which is scheduled to be released next week. I will update this issue when it is released. |
Any update on the signed SDKs release yet? |
@iOSNinja just a hint: you can use 10.23.0 with Xcode 14.2 as a workaround. I've just sent the app to the review, it passed the validation. |
Thanks for the workaround @wojciech-kulik but i've upgraded all our build machines to > Xcode15 and was waiting for firebase to release the signed SDKs today as mentioned above. |
The 10.24.0 zip release is now available. |
Has the Unity Firebase SDK provided signed xcframeworks for this points to version 10.24.0 of the iOS SDK which provided signed yet? Which version is it? |
This issue was fixed and released in 10.24.0. The Firebase Unity SDK was updated to use 10.24.0 in v11.9.0 (firebase/firebase-unity-sdk#991). There is now a newer Firebase version to use, so I recommend upgrading to the latest Firebase version (currently 10.25.0) as that included some additional fixes. The corresponding Firebase Unity SDK release should be the next Firebase Unity SDK release. |
Description
Third-party SDK XCFrameworks now need to be codesigned, not just the framework binaries within them. This will be enforced by Xcode at some point in Spring 2024.
https://developer.apple.com/support/third-party-SDK-requirements/
Note
xcframework
is a directory (bundle), not a binary. Though looks like Firebase binaries aren't codesigned either.Docs
https://developer.apple.com/documentation/xcode/verifying-the-origin-of-your-xcframeworks
https://developer.apple.com/videos/play/wwdc2023/10060/
cc @paulb777
(We're working on this for Flutter flutter/flutter#140934)
Reproducing the issue
Download XCFrameworks from https://firebase.google.com/docs/ios/setup#frameworks. Drag into Xcode 15+, see
Kind: Unsigned
in the inspector.Firebase SDK Version
10.19
Xcode Version
15
Installation Method
Zip
Firebase Product(s)
All
Targeted Platforms
iOS
Relevant Log Output
No response
The text was updated successfully, but these errors were encountered: