-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No such module 'Promises'
when building for testing on Xcode 15.0-beta5
#11656
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
@pgorrindo Thanks for the report. Would you check if |
thanks @paulb777 -- tried reseting package caches, same result as originally described. |
Hmm, we may need a reproducible example, since I'm able to successfully build Sessions for testing in beta 5. |
Here is a reproducible example @paulb777 -- https://github.com/whforward/promises-debugging -- a fresh new Xcode project created with Xcode 15-beta5, bringing in only the current 10.13.0 version of the Firebase SDK, and I get the results as described above. Greatly appreciate any insight you might have here. |
Thanks! I've reproduced and I'm investigating .... |
I've reduced the test case to determine it's sufficient to have only FirebasePerformance and FirebaseCrashlytics as dependencies of the test target. Removing one of them is sufficient to build successfully. We might want to do a bit more investigation, but my current thought is that this is an Xcode build system bug. A workaround may be to remove one of those two dependencies if you don't need to depend on both in the test target. |
Thanks @paulb777 -- ok, this is what I've found: recapitulate FirebaseCrashlytics + FirebasePerformanceIf I whittle down to just those two, I can reproduce what you see -- Promises error if both Crashlytics and Performance are present: and then by removing Performance, it builds: removing FirebasePerformance alone is insufficientbut if I add everything back, and only remove FirebasePerformance, then I get a new error, about undefined symbols in FirebaseFirestoreSwift: ultimately need to remove all Firestore, and FirebasePerformanceto get past the undefined symbols error, I needed to remove all three Firestore dependencies, and FirebasePerformance, to get be able to successfully Build for Running and Build for Testing: Thoughts?You are correct, Paul, that we don't need all of those dependencies for the test target. But we do need Firestore, unfortunately. Thoughts? |
Yes, I can reproduce with only FirebaseFirestoreSwift as a dependency of the test target:
|
Seems to be some sort of C++ symbol or linkage problem. I'm not sure why it only shows up in the test target. @ncooke3 any ideas? |
Beta 6 makes no difference on the Firestore grpc linkage problem. |
Hi @pgorrindo, I unfortunately don't have any advice to work around this issue at this time. We'll keep this open to verify against the issue against future betas. |
bummer, ok thanks for the update @ncooke3 |
Same with Xcode 15 Betas 7 and 8, and Firebase v10.14.0 -- the problem persists. |
Same with Xcode 15 Release Candidate, and Firebase v10.15.0 -- the problem persists in the minimal reproducible example previously noted. Trying |
Yep. I still see the C++ linkage issue from Firestore with the Xcode 15 RC. The original issue reported here of not being able to add both Crashlytics and Performance to the test target has been addressed. I suspect something about the Xcode 14 generated binary for Firestore may be missing something needed by Xcode 15. We'll continue to investigate. |
Hi @pgorrindo, we identified a fix for the undefined symbols errors. The fix should go out in the next release. Until then, I have a manual workaround that can help unblock your workflow.
You will need to repeat these steps if the DerivedData directory is deleted, or if you re-add Firebase via SPM. Let me know if you have any trouble. |
Description
We have been using the Firebase iOS SDK for some time in our iOS project. In looking to start using Xcode 15 exclusively, when using current versions of everything (specified below), we see the following issue, using the same Xcode project file:
No such module 'Promises
inFirebaseSessions
at line 21:@_implementationOnly import Promises
We've tried adding the
-ld64
other linker flag, cleaning the build and Derived Data folders, as well as removing and re-adding the Firebase package.Screenshot:
Reproducing the issue
No response
Firebase SDK Version
10.13.0
Xcode Version
15.0 beta 5 (15A5209g)
Installation Method
Swift Package Manager
Firebase Product(s)
All
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved
Expand
Package.resolved
snippetIf using CocoaPods, the project's Podfile.lock
Expand
Podfile.lock
snippetReplace this line with the contents of your Podfile.lock!
The text was updated successfully, but these errors were encountered: