Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using linkWithProvider #10267

Closed
Lyokone opened this issue Sep 27, 2022 · 10 comments
Closed

Error when using linkWithProvider #10267

Lyokone opened this issue Sep 27, 2022 · 10 comments
Labels
api: auth type: bug
Milestone
10.2.0 - M124

Comments

@Lyokone
Copy link

Lyokone commented Sep 27, 2022

Description

When using the linkWithProvider method and clicking on the "OK" button on the top left corner, the app crash with the following error:

Thread 34: "One of IDToken, accessToken, pendingToken, or requestURI must be supplied."

simulator_screenshot_F832AC73-4A77-4405-98BA-97298BE2D5FD

If I don't click on "OK" there are no issues

First reported in firebase/flutterfire#9615

Reproducing the issue

  [currentUser
      linkWithProvider:self.authProvider
            UIDelegate:nil
            completion:^(FIRAuthDataResult *authResult, NSError *error) {
              handleAppleAuthResult(self, arguments, auth, authResult.credential, error, result);
            }];

The completion is never called (checked by putting a breakpoint in it

Firebase SDK Version

9.6.0

Xcode Version

13.4.1

Installation Method

CocoaPods

Firebase Product(s)

Authentication

Targeted Platforms

iOS

Relevant Log Output

Thread 34: "One of IDToken, accessToken, pendingToken, or requestURI must be supplied."

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet 
Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet 
Replace this line with the contents of your Podfile.lock!
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@Albertbol
Copy link

Hey, pretty crucial bug for production, is there any news on this one, basically, your app crashes every time when the user cancels authentication.

@rizafran
Copy link
Contributor

Thanks for reporting this. I've tried reproducing the issue and I was able to get the same behavior. Let me check this with the team and see what we can do here.

@Albertbol
Copy link

Hey, any progress on this one? Pretty crucial bug.
Thanks

@Albertbol Albertbol mentioned this issue Oct 24, 2022
Open
@Albertbol
Copy link

Albertbol commented Oct 25, 2022 •
edited
Loading

Hey, any action on this?
There were a couple of pull requests already.
flutter/flutter#85785

@rizafran
Copy link
Contributor

Sorry for the trouble, @Albertbol. Our engineers are already looking into this issue, but I'll make a follow up about this.

@rizafran
Copy link
Contributor

rizafran commented Nov 3, 2022

Hello, thanks for your patience. Just to inform you that this issue has been fixed on #10407.

@paulb777 paulb777 added this to the 10.2.0 - M124 milestone Nov 3, 2022
@paulb777 paulb777 mentioned this issue Nov 4, 2022
Merged
@Lyokone
Copy link
Author

Lyokone commented Nov 4, 2022

Thanks for following up :)

@Lyokone Lyokone closed this as completed Nov 4, 2022
@Albertbol
Copy link

Hey, thank you very much for the fix. Could you estimate when it will be released? It's been almost a month and a half since the report and this bug actually prevents usage of fire_auth (breaks the ios app right away on cancel) so I believe it would have a high priority to be out.

@paulb777
Copy link
Member

paulb777 commented Nov 4, 2022

We plan to release it in 10.2.0 the week of November 14th

@firebase firebase locked and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: auth type: bug
Projects
None yet
Milestone
10.2.0 - M124
Development

No branches or pull requests
5 participants
@paulb777 @Lyokone @google-oss-bot @Albertbol @rizafran