Remote Config Dynamic Property Wrapper #10155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix retry logic to respect max retry count * Rename to isRequestInProgress
Coverage Report 1Affected Products
Test Logs |
charlotteliang
requested review from
karenyz,
paulb777,
erikeldridge and
ncooke3
karenyz
reviewed
Sep 12, 2022
karenyz
approved these changes
Sep 12, 2022
morganchen12
approved these changes
Sep 12, 2022
FirebaseRemoteConfigSwift/Apps/SwiftUISample/SwiftUISample/ContentView.swift
Outdated
Show resolved
Hide resolved
FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigValueObservable.swift
Outdated
Show resolved
Hide resolved
FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigValueObservable.swift
Show resolved
Hide resolved
|
Ignore the test failure since it's something we need to fix in the infra. |
|
Hi @chliangGoogle, I re-ran 40804aa's CI and PTAL at the results here: The 429 errors are gone, but there are 4 failures. Are these the failures you've been seeing? |
|
@ncooke3 yeah these are the same failure we've seen and we've run them successfully locally. |
karenyz
approved these changes
Sep 21, 2022
…ted by other tests
ncooke3
reviewed
Sep 22, 2022
… the config data in api test that affecting the results to be inaccurate
ncooke3
pushed a commit
that referenced
this pull request
Sep 24, 2022
ncooke3
added a commit
that referenced
this pull request
Sep 24, 2022
* [Firebase 10] Bump 9.X versions to 10.0.0 * Bump min. GTMSessionFetcher dep version to 2.1 * Bump min. GDT dep version to 9.2 * Bump min. GULs dep version to 7.8 * Fix unintentional nanopb replace * Fix unintentional nanopb replace (2) * Fix unintentional nanopb replace (3) * Fix unintentional nanopb replace (4) * Fix unintentional nanopb replace (4) * Trigger all CI * Bump FirebaseCombineSwift to 10 * Fix FirebaseStorage.podspec I'm not sure what happened here. I had committed it during the rebase but guess not? * Fix unintentional nanopb replace (5) * Disable two tests to unblock staging * Fix and re-enable FIROptions tests * Update deployment targets in Firebase.podspec * Add CHANGELOG entry for GTMSessionFetcher * Fix AppCheck iOS availability * Fix inadvertent API change (#10245) * Docs update for Extensions and putFile (#10248) * App google domain support (#10249) Adding new 1p domain "app.google" support in FDL SDK. * Remote Config Dynamic Property Wrapper (#10155) * Separate GoogleUtilities Carthage build (#10250) * Public count (#10246) * Public Count * Swift Test Commit * Swift Format * No extra whitespace * Hopefully formatted. * Change log and feedback. * Revert "Public count (#10246)" (#10252) This reverts commit 8aae6be. * Make Firestore use FirebaseDataEncoder and FirebaseDataDecoder (re-implementation of #8858) (#9465) * Bump tvOS minimum support version to 12.0 * [skip ci] Revert Gemfile Co-authored-by: Paul Beusterien <[email protected]> Co-authored-by: Eldhose M Babu <[email protected]> Co-authored-by: Charlotte Liang <[email protected]> Co-authored-by: wu-hui <[email protected]> Co-authored-by: Morten Bek Ditlevsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new API that enables developers to define a property wrapper that listens to a remote config key value. When remote config is activated, the UI component will automatically reflect the activated value.