Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregations API proposal #3522

Draft
wants to merge 1 commit into
base: dconeybe/CountApi
Choose a base branch
from
Draft

Conversation

dconeybe
Copy link
Contributor

DO NOT MERGE - This PR is only created to get initial feedback. This PR will eventually be deleted.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.LatencyCompensationMode [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (bacc0e1) to 50.12% (92c0330) by -0.02%.

    FilenameBase (bacc0e1)Merge (92c0330)Diff
    DoubleNode.java100.00%88.24%-11.76%
  • firebase-messaging

    Overall coverage changed from 85.11% (bacc0e1) to 85.15% (92c0330) by +0.04%.

    FilenameBase (bacc0e1)Merge (92c0330)Diff
    FirebaseMessaging.java74.89%75.33%+0.44%
  • firebase-perf

    Overall coverage changed from 71.38% (bacc0e1) to 71.35% (92c0330) by -0.03%.

    FilenameBase (bacc0e1)Merge (92c0330)Diff
    TransportManager.java94.88%93.95%-0.93%

Test Logs

Notes

  • Commit (92c0330) is created by Prow via merging PR base commit (bacc0e1) and head commit (8e7fd39).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uD3pO4yche.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 10, 2022

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (98ec319)Merge (c921764)Diff
    aar1.26 MB1.28 MB+16.6 kB (+1.3%)
    apk (release)3.39 MB3.39 MB+5.49 kB (+0.2%)
  • firebase-firestore-ktx

    TypeBase (98ec319)Merge (c921764)Diff
    aar7.45 kB7.84 kB+388 B (+5.2%)
    apk (release)3.87 MB3.87 MB+3.07 kB (+0.1%)

Test Logs

Notes

  • Commit (c921764) is created by Prow via merging PR base commit (98ec319) and head commit (45d368c).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AmG31nldg1.html

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from a41cd22 to 08db37c Compare March 10, 2022 20:41
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateExecutionMode [AddedClass]
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count(com.google.firebase.firestore.AggregateExecutionMode) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 08db37c to 0ab670b Compare March 17, 2022 19:20
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateExecutionMode [AddedClass]
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count(com.google.firebase.firestore.AggregateExecutionMode) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 0ab670b to cf7973a Compare March 17, 2022 19:38
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateExecutionMode [AddedClass]
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count(com.google.firebase.firestore.AggregateExecutionMode) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.AggregateExecutionMode,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from cf7973a to e6ba0fa Compare May 26, 2022 19:34
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from e6ba0fa to 120d996 Compare June 3, 2022 19:04
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 120d996 to ad0cffd Compare June 17, 2022 18:55
@dconeybe dconeybe changed the base branch from master to dconeybe/CountApi June 17, 2022 18:57
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/CountApi branch from 57caecf to 98ec319 Compare June 20, 2022 19:58
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from ad0cffd to 45d368c Compare June 20, 2022 20:24
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.AggregateSnapshot,com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,String,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]
error: Added method com.google.firebase.firestore.ktx.FirestoreKt.getField(com.google.firebase.firestore.GroupSnapshot,com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.DocumentSnapshot.ServerTimestampBehavior) [AddedMethod]

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/CountApi branch 2 times, most recently from 7d4a66e to 434ebfe Compare July 27, 2022 20:32
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 45d368c to abd4057 Compare July 28, 2022 15:45
@dconeybe dconeybe force-pushed the dconeybe/CountApi branch from 434ebfe to e57fa9e Compare August 2, 2022 19:20
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from abd4057 to 7edeb63 Compare August 2, 2022 19:21
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@dconeybe dconeybe force-pushed the dconeybe/CountApi branch from e57fa9e to bacc0e1 Compare August 3, 2022 02:11
@dconeybe dconeybe force-pushed the dconeybe/AggregateApi branch from 7edeb63 to 8e7fd39 Compare August 3, 2022 02:12
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added class com.google.firebase.firestore.AggregateField [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuery [AddedClass]
error: Added class com.google.firebase.firestore.AggregateQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSnapshot [AddedClass]
error: Added class com.google.firebase.firestore.AggregateSource [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuery [AddedClass]
error: Added class com.google.firebase.firestore.GroupByQuerySnapshot [AddedClass]
error: Added class com.google.firebase.firestore.GroupBySource [AddedClass]
error: Added class com.google.firebase.firestore.GroupChange [AddedClass]
error: Added class com.google.firebase.firestore.GroupSnapshot [AddedClass]
error: Added method com.google.firebase.firestore.Query.aggregate(com.google.firebase.firestore.AggregateField,com.google.firebase.firestore.AggregateField...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.count() [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(String,java.lang.String...) [AddedMethod]
error: Added method com.google.firebase.firestore.Query.groupBy(com.google.firebase.firestore.FieldPath,com.google.firebase.firestore.FieldPath...) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

@dconeybe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 45d368c link /test device-check-changed
smoke-tests 8e7fd39 link /test smoke-tests
binary-size 8e7fd39 link /run binary-size
api-information 8e7fd39 link /test api-information
check-changed 8e7fd39 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants