Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertexAI authorization header #6400

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fix vertexAI authorization header #6400

merged 4 commits into from
Oct 22, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 22, 2024

The header for authenticated request from vertex was using an invalid authorization value

The header for authenticated request from vertex was using an invalid
authorization value
@rlazo rlazo requested review from daymxn and emilypgoogle October 22, 2024 20:31
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-vertexai
### {{firebase_vertexai}} version 16.0.1 {: #vertex-ai_v16-0-1}

* {{fixed}} Fixed issue where authorization headers weren't correctly formatted and were ignored by the backend. GitHub [#6400](//github.com/firebase/firebase-android-sdk/issues/6400){: .external}

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Test Results

 20 files   20 suites   14s ⏱️
112 tests 112 ✅ 0 💤 0 ❌
224 runs  224 ✅ 0 💤 0 ❌

Results for commit f6bd49b.

♻️ This comment has been updated with latest results.

@rlazo rlazo requested a review from rachelsaunders October 22, 2024 20:41
firebase-vertexai/CHANGELOG.md Outdated Show resolved Hide resolved
@rlazo rlazo merged commit bcb4607 into main Oct 22, 2024
27 checks passed
@rlazo rlazo deleted the rl.vertex.auth branch October 22, 2024 20:52
@firebase firebase locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants