Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize protos #6369

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Synchronize protos #6369

merged 6 commits into from
Oct 11, 2024

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 10, 2024 •
edited
Loading

This is a result of comparison with official Firestore protos.

Note, some gRPC endpoint and message additions were omitted since we have no plans of supporting them in SDK.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-firestore 
### {{firestore}} version 25.1.1 {: #firestore_v25-1-1}

* {{changed}} Update Firestore proto definitions. GitHub [#6369](//github.com/firebase/firebase-android-sdk/issues/6369){: .external}

* {{changed}} Updated protobuf dependency to `3.25.5` to fix
  [CVE-2024-7254](https://github.com/advisories/GHSA-735f-pc8j-v9w8).

#### {{firestore}} Kotlin extensions version 25.1.1 {: #firestore-ktx_v25-1-1}

The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Test Results

  186 files  +  166    186 suites  +166   4m 26s ⏱️ + 4m 12s
1 234 tests +1 122  1 218 ✅ +1 106  16 💤 +16  0 ❌ ±0 
2 492 runs  +2 268  2 460 ✅ +2 236  32 💤 +32  0 ❌ ±0 

Results for commit 288a559. ± Comparison against base commit 2d6c899.

This pull request removes 112 and adds 1234 tests. Note that renamed tests count towards both. 
com.google.firebase.vertexai.GenerativeModelTesting ‑ addition
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.StreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.vertexai.StreamingSnapshotTests ‑ empty content
com.google.firebase.vertexai.StreamingSnapshotTests ‑ http errors
com.google.firebase.vertexai.StreamingSnapshotTests ‑ image rejected
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid api key
com.google.firebase.vertexai.StreamingSnapshotTests ‑ invalid json
com.google.firebase.vertexai.StreamingSnapshotTests ‑ long reply
…

com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…

♻️ This comment has been updated with latest results.

@tom-andersen tom-andersen marked this pull request as ready for review October 10, 2024 19:58
@tom-andersen tom-andersen merged commit 60a5e4c into main Oct 11, 2024
29 checks passed
@tom-andersen tom-andersen deleted the tomandersen/updateProtos branch October 11, 2024 18:14
@firebase firebase locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tom-andersen @ehsannas @google-oss-bot