Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for the VectorValue type #6154

Merged
merged 11 commits into from
Aug 8, 2024

Conversation

MarkDuckworth
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-firestore/_toc.yaml	2024-08-08 02:26:21.585795228 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-firestore/_toc.yaml	2024-08-08 02:23:48.983960992 +0000
@@ -104,6 +104,8 @@
       path: "/docs/reference/android/com/google/firebase/firestore/TransactionOptions.html"
     - title: "TransactionOptions.Builder"
       path: "/docs/reference/android/com/google/firebase/firestore/TransactionOptions.Builder.html"
+    - title: "VectorValue"
+      path: "/docs/reference/android/com/google/firebase/firestore/VectorValue.html"
     - title: "WriteBatch"
       path: "/docs/reference/android/com/google/firebase/firestore/WriteBatch.html"
 
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentSnapshot.html	2024-08-08 02:26:21.545794766 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentSnapshot.html	2024-08-08 02:23:48.979960949 +0000
@@ -284,6 +284,13 @@
             </td>
           </tr>
           <tr>
+            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;field)</code></div>
+              <p>Returns the value of the field as a <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code>int</code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html#hashCode()">hashCode</a>()</code></div>
@@ -1852,6 +1859,74 @@
                 </td>
               </tr>
             </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="getVectorValue-java.lang.String-"></a><a name="getvectorvalue"></a>
+        <h3 class="api-name" id="getVectorValue(java.lang.String)">getVectorValue</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;field)</pre>
+        <p>Returns the value of the field as a <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;field</code></td>
+                <td>
+                  <p>The path to the field.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+                <td>
+                  <p>The value of the field.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Throws</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/RuntimeException.html">java.lang.RuntimeException</a>&nbsp;java.lang.RuntimeException</code></td>
+                <td>
+                  <p>if the value is not a VectorValue.</p>
+                </td>
+              </tr>
+            </tbody>
           </table>
         </div>
       </div>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FieldValue.html	2024-08-08 02:26:21.541794720 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FieldValue.html	2024-08-08 02:23:48.963960777 +0000
@@ -68,6 +68,13 @@
               <p>Returns a sentinel for use with <code>set()</code> or <code>update()</code> to include a server-generated timestamp in the written data.</p>
             </td>
           </tr>
+          <tr>
+            <td><code>static @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]&nbsp;values)</code></div>
+              <p>Creates a new <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+            </td>
+          </tr>
         </tbody>
       </table>
     </div>
@@ -232,6 +239,53 @@
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/FieldValue.html">FieldValue</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FieldValue.html#serverTimestamp()">serverTimestamp</a>()</pre>
         <p>Returns a sentinel for use with <code>set()</code> or <code>update()</code> to include a server-generated timestamp in the written data.</p>
       </div>
+      <div class="api-item"><a name="vector-double[]-"></a><a name="vector"></a>
+        <h3 class="api-name" id="vector(double[])">vector</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]&nbsp;values)</pre>
+        <p>Creates a new <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]&nbsp;values</code></td>
+                <td>
+                  <p>Array of doubles to be copied to create a <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code>.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+                <td>
+                  <p>A new <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
     </div>
   </body>
 </html>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/QueryDocumentSnapshot.html	2024-08-08 02:26:21.541794720 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/QueryDocumentSnapshot.html	2024-08-08 02:23:48.963960777 +0000
@@ -346,6 +346,13 @@
                       </td>
                     </tr>
                     <tr>
+                      <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+                      <td>
+                        <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;field)</code></div>
+                        <p>Returns the value of the field as a <code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+                      </td>
+                    </tr>
+                    <tr>
                       <td><code>int</code></td>
                       <td>
                         <div><code><a href="/docs/reference/android/com/google/firebase/firestore/DocumentSnapshot.html#hashCode()">hashCode</a>()</code></div>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/VectorValue.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/VectorValue.html	2024-08-08 02:23:48.983960992 +0000
@@ -0,0 +1,133 @@
+<html devsite="true">
+  <head>
+    <title>VectorValue</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+  </head>
+  <body>
+    <div id="metadata-info-block"></div>
+    <h1>VectorValue</h1>
+    <p>
+      <pre>public class <a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></pre>
+    </p>
+    <hr>
+    <p>Represent a vector type in Firestore documents. Create an instance with <code><a href="/docs/reference/android/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a></code>.</p>
+    <h2>Summary</h2>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public methods</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code>boolean</code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#equals(java.lang.Object)">equals</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;obj)</code></div>
+              <p>Returns true if this VectorValue is equal to the provided object.</p>
+            </td>
+          </tr>
+          <tr>
+            <td><code>int</code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#hashCode()">hashCode</a>()</code></div>
+            </td>
+          </tr>
+          <tr>
+            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]</code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#toArray()">toArray</a>()</code></div>
+              <p>Returns a representation of the vector as an array of doubles.</p>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="list">
+      <h2>Public methods</h2>
+      <div class="api-item"><a name="equals-java.lang.Object-"></a><a name="equals"></a>
+        <h3 class="api-name" id="equals(java.lang.Object)">equals</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;boolean&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#equals(java.lang.Object)">equals</a>(<a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;obj)</pre>
+        <p>Returns true if this VectorValue is equal to the provided object.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;obj</code></td>
+                <td>
+                  <p>The object to compare against.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>boolean</code></td>
+                <td>
+                  <p>Whether this VectorValue is equal to the provided object.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="hashCode--"></a><a name="hashcode"></a>
+        <h3 class="api-name" id="hashCode()">hashCode</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;int&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#hashCode()">hashCode</a>()</pre>
+      </div>
+      <div class="api-item"><a name="toArray--"></a><a name="toarray"></a>
+        <h3 class="api-name" id="toArray()">toArray</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html#toArray()">toArray</a>()</pre>
+        <p>Returns a representation of the vector as an array of doubles.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> double[]</code></td>
+                <td>
+                  <p>A representation of the vector as an array of doubles</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+    </div>
+  </body>
+</html>
+
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/package-summary.html	2024-08-08 02:26:21.529794582 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/package-summary.html	2024-08-08 02:23:48.963960777 +0000
@@ -348,6 +348,12 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="/docs/reference/android/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+            <td>
+              <p>Represent a vector type in Firestore documents.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="/docs/reference/android/com/google/firebase/firestore/WriteBatch.html">WriteBatch</a></code></td>
             <td>
               <p>A write batch, used to perform multiple writes as a single atomic unit.</p>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/client/firebase-firestore/_toc.yaml	2024-08-08 02:26:21.529794582 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/client/firebase-firestore/_toc.yaml	2024-08-08 02:23:48.959960734 +0000
@@ -102,6 +102,8 @@
       path: "/docs/reference/kotlin/com/google/firebase/firestore/TransactionOptions.html"
     - title: "TransactionOptions.Builder"
       path: "/docs/reference/kotlin/com/google/firebase/firestore/TransactionOptions.Builder.html"
+    - title: "VectorValue"
+      path: "/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html"
     - title: "WriteBatch"
       path: "/docs/reference/kotlin/com/google/firebase/firestore/WriteBatch.html"
 
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentSnapshot.html	2024-08-08 02:26:21.509794350 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/DocumentSnapshot.html	2024-08-08 02:23:48.943960562 +0000
@@ -257,6 +257,13 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a>?</code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(field:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
+              <p>Returns the value of the field as a <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html#hashCode()">hashCode</a>()</code></div>
@@ -1814,6 +1821,74 @@
                 </td>
               </tr>
             </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="getVectorValue-java.lang.String-"></a><a name="getvectorvalue"></a>
+        <h3 class="api-name" id="getVectorValue(java.lang.String)">getVectorValue</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(field:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a>?</pre>
+        <p>Returns the value of the field as a <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>field:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></code></td>
+                <td>
+                  <p>The path to the field.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a>?</code></td>
+                <td>
+                  <p>The value of the field.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Throws</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>java.lang.RuntimeException:&nbsp;<a href="https://developer.android.com/reference/kotlin/java/lang/RuntimeException.html">java.lang.RuntimeException</a></code></td>
+                <td>
+                  <p>if the value is not a VectorValue.</p>
+                </td>
+              </tr>
+            </tbody>
           </table>
         </div>
       </div>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FieldValue.html	2024-08-08 02:26:21.501794258 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FieldValue.html	2024-08-08 02:23:48.943960562 +0000
@@ -68,6 +68,13 @@
               <p>Returns a sentinel for use with <code>set()</code> or <code>update()</code> to include a server-generated timestamp in the written data.</p>
             </td>
           </tr>
+          <tr>
+            <td><code>java-static <a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a>(values:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a>)</code></div>
+              <p>Creates a new <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+            </td>
+          </tr>
         </tbody>
       </table>
     </div>
@@ -232,6 +239,53 @@
         <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FieldValue.html#serverTimestamp()">serverTimestamp</a>():&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FieldValue.html">FieldValue</a></pre>
         <p>Returns a sentinel for use with <code>set()</code> or <code>update()</code> to include a server-generated timestamp in the written data.</p>
       </div>
+      <div class="api-item"><a name="vector-double[]-"></a><a name="vector"></a>
+        <h3 class="api-name" id="vector(double[])">vector</h3>
+        <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a>(values:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></pre>
+        <p>Creates a new <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>values:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a></code></td>
+                <td>
+                  <p>Array of doubles to be copied to create a <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code>.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+                <td>
+                  <p>A new <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> constructed with a copy of the given array of doubles.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
     </div>
   </body>
 </html>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/QueryDocumentSnapshot.html	2024-08-08 02:26:21.505794305 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/QueryDocumentSnapshot.html	2024-08-08 02:23:48.943960562 +0000
@@ -315,6 +315,13 @@
                       </td>
                     </tr>
                     <tr>
+                      <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a>?</code></td>
+                      <td>
+                        <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html#getVectorValue(java.lang.String)">getVectorValue</a>(field:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
+                        <p>Returns the value of the field as a <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code> or `null` if the field does not exist in the document.</p>
+                      </td>
+                    </tr>
+                    <tr>
                       <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
                       <td>
                         <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/DocumentSnapshot.html#hashCode()">hashCode</a>()</code></div>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/VectorValue.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/VectorValue.html	2024-08-08 02:23:48.959960734 +0000
@@ -0,0 +1,133 @@
+<html devsite="true">
+  <head>
+    <title>VectorValue</title>
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/kotlin/_reference-head-tags.html" %}
+  </head>
+  <body>
+    <div id="metadata-info-block"></div>
+    <h1>VectorValue</h1>
+    <p>
+      <pre>class <a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></pre>
+    </p>
+    <hr>
+    <p>Represent a vector type in Firestore documents. Create an instance with <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FieldValue.html#vector(double[])">vector</a></code>.</p>
+    <h2>Summary</h2>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public functions</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#equals(java.lang.Object)">equals</a>(obj:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!)</code></div>
+              <p>Returns true if this VectorValue is equal to the provided object.</p>
+            </td>
+          </tr>
+          <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#hashCode()">hashCode</a>()</code></div>
+            </td>
+          </tr>
+          <tr>
+            <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double/index.html">Double</a>&gt;</code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#toArray()">toArray</a>()</code></div>
+              <p>Returns a representation of the vector as an array of doubles.</p>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="list">
+      <h2>Public functions</h2>
+      <div class="api-item"><a name="equals-java.lang.Object-"></a><a name="equals"></a>
+        <h3 class="api-name" id="equals(java.lang.Object)">equals</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#equals(java.lang.Object)">equals</a>(obj:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></pre>
+        <p>Returns true if this VectorValue is equal to the provided object.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Parameters</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code>obj:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>!</code></td>
+                <td>
+                  <p>The object to compare against.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-boolean/index.html">Boolean</a></code></td>
+                <td>
+                  <p>Whether this VectorValue is equal to the provided object.</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+      <div class="api-item"><a name="hashCode--"></a><a name="hashcode"></a>
+        <h3 class="api-name" id="hashCode()">hashCode</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#hashCode()">hashCode</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-int/index.html">Int</a></pre>
+      </div>
+      <div class="api-item"><a name="toArray--"></a><a name="toarray"></a>
+        <h3 class="api-name" id="toArray()">toArray</h3>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html#toArray()">toArray</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double/index.html">Double</a>&gt;</pre>
+        <p>Returns a representation of the vector as an array of doubles.</p>
+        <div class="devsite-table-wrapper">
+          <table class="responsive">
+            <colgroup>
+              <col width="40%">
+              <col>
+            </colgroup>
+            <thead>
+              <tr>
+                <th colspan="100%">Returns</th>
+              </tr>
+            </thead>
+            <tbody class="list">
+              <tr>
+                <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double-array/index.html">DoubleArray</a>&lt;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-double/index.html">Double</a>&gt;</code></td>
+                <td>
+                  <p>A representation of the vector as an array of doubles</p>
+                </td>
+              </tr>
+            </tbody>
+          </table>
+        </div>
+      </div>
+    </div>
+  </body>
+</html>
+
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/package-summary.html	2024-08-08 02:26:21.501794258 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/package-summary.html	2024-08-08 02:23:48.939960519 +0000
@@ -297,6 +297,12 @@
             </td>
           </tr>
           <tr>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/VectorValue.html">VectorValue</a></code></td>
+            <td>
+              <p>Represent a vector type in Firestore documents.</p>
+            </td>
+          </tr>
+          <tr>
             <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/WriteBatch.html">WriteBatch</a></code></td>
             <td>
               <p>A write batch, used to perform multiple writes as a single atomic unit.</p>

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.DocumentSnapshot.getVectorValue(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FieldValue.vector(double[]) [AddedMethod]
error: Added class com.google.firebase.firestore.VectorValue [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@MarkDuckworth MarkDuckworth changed the title VectorValue type support for Firestore. feat: VectorValue type support for Firestore. Aug 5, 2024
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.DocumentSnapshot.getVectorValue(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FieldValue.vector(double[]) [AddedMethod]
error: Added class com.google.firebase.firestore.VectorValue [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.DocumentSnapshot.getVectorValue(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FieldValue.vector(double[]) [AddedMethod]
error: Added class com.google.firebase.firestore.VectorValue [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 5, 2024

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.89% (8c04ec2) to 45.98% (3d12627) by +0.10%.

    FilenameBase (8c04ec2)Merge (3d12627)Diff
    CustomClassMapper.java84.44%83.74%-0.70%
    DocumentSnapshot.java53.13%52.58%-0.55%
    FieldValue.java82.14%82.76%+0.62%
    FirestoreIndexValueWriter.java77.11%82.11%+5.00%
    SetMutation.java97.22%94.44%-2.78%
    UserDataReader.java70.48%71.30%+0.82%
    UserDataWriter.java51.02%44.64%-6.38%
    Values.java95.65%96.52%+0.86%
    VectorValue.java?46.67%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ik7UwQ7dOO.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.DocumentSnapshot.getVectorValue(String) [AddedMethod]
error: Added method com.google.firebase.firestore.FieldValue.vector(double[]) [AddedMethod]
error: Added class com.google.firebase.firestore.VectorValue [AddedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Unit Test Results

   186 files  +   122     186 suites  +122   4m 40s ⏱️ - 1m 42s
1 234 tests +   747  1 218 ✔️ +   731  16 💤 +16  0 ±0 
2 492 runs  +1 512  2 460 ✔️ +1 480  32 💤 +32  0 ±0 

Results for commit 0a3204e. ± Comparison against base commit 8c04ec2.

This pull request removes 487 and adds 1234 tests. Note that renamed tests count towards both.
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[24]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_preO[22]
…
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 5, 2024

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (8c04ec2)Merge (3d12627)Diff
    aar1.43 MB1.44 MB+2.61 kB (+0.2%)
    apk (release)11.3 MB11.3 MB+2.51 kB (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bOA2WRWkh1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 5, 2024

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile8c04ec23d12627DiffSignificant (?)
    p10337 ±24 μs328 ±26 μs-8.18 μs (-2.4%)NO
    p25350 ±25 μs341 ±28 μs-8.90 μs (-2.5%)NO
    p50370 ±30 μs372 ±44 μs+1.98 μs (+0.5%)NO
    p75438 ±86 μs453 ±104 μs+15.3 μs (+3.5%)NO
    p90499 ±124 μs563 ±161 μs+63.8 μs (+12.8%)NO

    20 test runs in comparison
    CommitTest Runs
    8c04ec2
    • 2024-08-07_18:21:29.175670_NiGM
    • 2024-08-07_18:21:29.175713_ySFI
    • 2024-08-07_18:21:29.175724_eZRi
    • 2024-08-07_18:21:29.175731_fLIi
    • 2024-08-07_18:21:29.175744_aXbf
    • 2024-08-07_18:21:29.175751_pRBa
    • 2024-08-07_18:21:29.175757_cizb
    • 2024-08-07_18:21:29.175764_DChr
    • 2024-08-07_18:21:29.175771_YoUR
    • 2024-08-07_18:21:29.175778_kwow
    3d12627
    • 2024-08-08_02:32:20.729879_GeUV
    • 2024-08-08_02:32:20.729916_lsBs
    • 2024-08-08_02:32:20.729923_gTRC
    • 2024-08-08_02:32:20.729928_KbgI
    • 2024-08-08_02:32:20.729941_FENB
    • 2024-08-08_02:32:20.729946_ZLms
    • 2024-08-08_02:32:20.729950_Rjzq
    • 2024-08-08_02:32:20.729954_nWFM
    • 2024-08-08_02:32:20.729958_vrJN
    • 2024-08-08_02:32:20.729961_CnjK
    redfin-30
    Percentile8c04ec23d12627DiffSignificant (?)
    p10611 ±54 μs608 ±54 μs-3.00 μs (-0.5%)NO
    p25629 ±59 μs622 ±56 μs-7.62 μs (-1.2%)NO
    p50658 ±67 μs646 ±68 μs-12.1 μs (-1.8%)NO
    p75689 ±69 μs674 ±78 μs-14.8 μs (-2.1%)NO
    p90725 ±80 μs721 ±107 μs-4.75 μs (-0.7%)NO

    20 test runs in comparison
    CommitTest Runs
    8c04ec2
    • 2024-08-07_18:21:29.175670_NiGM
    • 2024-08-07_18:21:29.175713_ySFI
    • 2024-08-07_18:21:29.175724_eZRi
    • 2024-08-07_18:21:29.175731_fLIi
    • 2024-08-07_18:21:29.175744_aXbf
    • 2024-08-07_18:21:29.175751_pRBa
    • 2024-08-07_18:21:29.175757_cizb
    • 2024-08-07_18:21:29.175764_DChr
    • 2024-08-07_18:21:29.175771_YoUR
    • 2024-08-07_18:21:29.175778_kwow
    3d12627
    • 2024-08-08_02:32:20.729879_GeUV
    • 2024-08-08_02:32:20.729916_lsBs
    • 2024-08-08_02:32:20.729923_gTRC
    • 2024-08-08_02:32:20.729928_KbgI
    • 2024-08-08_02:32:20.729941_FENB
    • 2024-08-08_02:32:20.729946_ZLms
    • 2024-08-08_02:32:20.729950_Rjzq
    • 2024-08-08_02:32:20.729954_nWFM
    • 2024-08-08_02:32:20.729958_vrJN
    • 2024-08-08_02:32:20.729961_CnjK
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile8c04ec23d12627DiffSignificant (?)
    p10204 ±7 ms208 ±4 ms+4.03 ms (+2.0%)NO
    p25209 ±8 ms213 ±4 ms+3.75 ms (+1.8%)NO
    p50217 ±8 ms221 ±5 ms+3.21 ms (+1.5%)NO
    p75224 ±8 ms230 ±6 ms+5.54 ms (+2.5%)NO
    p90233 ±10 ms242 ±11 ms+9.30 ms (+4.0%)NO

    20 test runs in comparison
    CommitTest Runs
    8c04ec2
    • 2024-08-07_18:21:29.175670_NiGM
    • 2024-08-07_18:21:29.175713_ySFI
    • 2024-08-07_18:21:29.175724_eZRi
    • 2024-08-07_18:21:29.175731_fLIi
    • 2024-08-07_18:21:29.175744_aXbf
    • 2024-08-07_18:21:29.175751_pRBa
    • 2024-08-07_18:21:29.175757_cizb
    • 2024-08-07_18:21:29.175764_DChr
    • 2024-08-07_18:21:29.175771_YoUR
    • 2024-08-07_18:21:29.175778_kwow
    3d12627
    • 2024-08-08_02:32:20.729879_GeUV
    • 2024-08-08_02:32:20.729916_lsBs
    • 2024-08-08_02:32:20.729923_gTRC
    • 2024-08-08_02:32:20.729928_KbgI
    • 2024-08-08_02:32:20.729941_FENB
    • 2024-08-08_02:32:20.729946_ZLms
    • 2024-08-08_02:32:20.729950_Rjzq
    • 2024-08-08_02:32:20.729954_nWFM
    • 2024-08-08_02:32:20.729958_vrJN
    • 2024-08-08_02:32:20.729961_CnjK
    redfin-30
    Percentile8c04ec23d12627DiffSignificant (?)
    p10247 ±14 ms270 ±17 ms+22.1 ms (+8.9%)NO
    p25253 ±14 ms275 ±17 ms+21.2 ms (+8.4%)NO
    p50260 ±14 ms283 ±17 ms+22.7 ms (+8.7%)NO
    p75268 ±14 ms292 ±17 ms+23.9 ms (+8.9%)NO
    p90278 ±16 ms306 ±17 ms+28.7 ms (+10.3%)NO

    20 test runs in comparison
    CommitTest Runs
    8c04ec2
    • 2024-08-07_18:21:29.175670_NiGM
    • 2024-08-07_18:21:29.175713_ySFI
    • 2024-08-07_18:21:29.175724_eZRi
    • 2024-08-07_18:21:29.175731_fLIi
    • 2024-08-07_18:21:29.175744_aXbf
    • 2024-08-07_18:21:29.175751_pRBa
    • 2024-08-07_18:21:29.175757_cizb
    • 2024-08-07_18:21:29.175764_DChr
    • 2024-08-07_18:21:29.175771_YoUR
    • 2024-08-07_18:21:29.175778_kwow
    3d12627
    • 2024-08-08_02:32:20.729879_GeUV
    • 2024-08-08_02:32:20.729916_lsBs
    • 2024-08-08_02:32:20.729923_gTRC
    • 2024-08-08_02:32:20.729928_KbgI
    • 2024-08-08_02:32:20.729941_FENB
    • 2024-08-08_02:32:20.729946_ZLms
    • 2024-08-08_02:32:20.729950_Rjzq
    • 2024-08-08_02:32:20.729954_nWFM
    • 2024-08-08_02:32:20.729958_vrJN
    • 2024-08-08_02:32:20.729961_CnjK

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YL1Ue0IFxG/index.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Class com.google.firebase.firestore.VectorValue no longer implements java.io.Serializable [RemovedInterface]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Class com.google.firebase.firestore.VectorValue no longer implements java.io.Serializable [RemovedInterface]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Class com.google.firebase.firestore.VectorValue no longer implements java.io.Serializable [RemovedInterface]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-firestore:
error: Class com.google.firebase.firestore.VectorValue no longer implements java.io.Serializable [RemovedInterface]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@MarkDuckworth MarkDuckworth changed the title feat: VectorValue type support for Firestore. feat: Add support for the VectorValue type Aug 8, 2024
@MarkDuckworth MarkDuckworth merged commit 57aaf39 into main Aug 8, 2024
32 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/vector-type branch August 8, 2024 02:52
Copy link

@markarndt markarndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...

@@ -182,4 +182,15 @@ public static FieldValue increment(long l) {
public static FieldValue increment(double l) {
return new NumericIncrementFieldValue(l);
}

/**
* Creates a new {@link VectorValue} constructed with a copy of the given array of doubles.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're changing Creates -> Represents per egilmore comment on the js sdk version, apply same changes here AND in the Apple plat/iOS version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@firebase firebase locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants