Replace Collection.emptyMap() with new HashMap() #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 24.10.1 {: #firestore_v24-10-1}
* {{fixed}} Fixed an issue caused by calling mutation on immutable map object. GitHub [#5573](//github.com/firebase/firebase-android-sdk/issues/5573){: .external}
* {{fixed}} Fixed an issue in the local cache synchronization logic where all locally-cached documents that matched a resumed query would be unnecessarily re-downloaded; with the fix it now only downloads the documents that are known to be out-of-sync. GitHub [#5506](//github.com/firebase/firebase-android-sdk/issues/5506){: .external}
* {{fixed}} Fixed an issue where GC runs into a infinite loop in a certain case. GitHub [#5417](//github.com/firebase/firebase-android-sdk/issues/5417){: .external}
#### {{firestore}} Kotlin extensions version 24.10.1 {: #firestore-ktx_v24-10-1}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 180 files + 174 180 suites +174 4m 0s ⏱️ + 3m 41s Results for commit 3539251. ± Comparison against base commit ac19e5d5. This pull request removes 19 and adds 1226 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
milaGGL
changed the title
|
Any updates on this when will this be merged? |
dconeybe
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #5571