Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m137 release #5337

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Fix m137 release #5337

merged 6 commits into from
Sep 15, 2023

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-crashlytics-ndk
### {{crashlytics}} NDK version 18.4.3 {: #crashlytics-ndk_v18-4-3}

* {{changed}} Updated `firebase-crashlytics` dependency to v18.4.3
firebase-crashlytics
### {{crashlytics}} version 18.4.3 {: #crashlytics_v18-4-3}

* {{fixed}} Disabled `GradleMetadataPublishing` to fix breakage of the Kotlin extensions library. #5337

#### {{crashlytics}} Kotlin extensions version 18.4.3 {: #crashlytics-ktx_v18-4-3}

The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates.
firebase-firestore
### {{firestore}} version 24.8.1 {: #firestore_v24-8-1}

* {{fixed}} Disabled `GradleMetadataPublishing` to fix breakage of the Kotlin extensions library. #5337

#### {{firestore}} Kotlin extensions version 24.8.1 {: #firestore-ktx_v24-8-1}

The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
firebase-inappmessaging-display
### {{inappmessaging}} Display version 20.3.5 {: #inappmessaging-display_v20-3-5}

* {{fixed}} Disabled `GradleMetadataPublishing` to fix breakage of the Kotlin extensions library. #5337

#### {{inappmessaging}} Display Kotlin extensions version 20.3.5 {: #inappmessaging-display-ktx_v20-3-5}

The Kotlin extensions library transitively includes the updated
`firebase-inappmessaging-display` library. The Kotlin extensions library has no additional
updates.
firebase-inappmessaging
### {{inappmessaging}} version 20.3.5 {: #inappmessaging_v20-3-5}

* {{fixed}} Disabled `GradleMetadataPublishing` to fix breakage of the Kotlin extensions library. #5337

#### {{inappmessaging}} Kotlin extensions version 20.3.5 {: #inappmessaging-ktx_v20-3-5}

The Kotlin extensions library transitively includes the updated
`firebase-inappmessaging` library. The Kotlin extensions library has no additional
updates.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

buildSrc Test Results

36 tests   36 ✔️  1m 36s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit dbd101b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

Unit Test Results

   803 files  +   553     803 suites  +553   36m 39s ⏱️ + 30m 29s
5 008 tests +3 351  4 985 ✔️ +3 345  21 💤 +4  2 +2 
9 737 runs  +6 423  9 693 ✔️ +6 413  42 💤 +8  2 +2 

For more details on these failures, see this check.

Results for commit dbd101b. ± Comparison against base commit 924641b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (ceff4dd) and the base commit (924641b) are not available.

No macrobenchmark data found for the base commit (924641b). Analysis for the CI merge commit (ceff4dd) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/t0E3KFGsUH/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (924641b) to 50.13% (ceff4dd) by -0.04%.

    FilenameBase (924641b)Merge (ceff4dd)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-firestore

    Overall coverage changed from 44.62% (924641b) to 44.62% (ceff4dd) by -0.00%.

    FilenameBase (924641b)Merge (ceff4dd)Diff
    SetMutation.java97.22%94.44%-2.78%
  • firebase-installations

    Overall coverage changed from ? (924641b) to 58.61% (ceff4dd) by ?.

    22 individual files with coverage change

    FilenameBase (924641b)Merge (ceff4dd)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.21% (924641b) to 84.14% (ceff4dd) by -0.08%.

    FilenameBase (924641b)Merge (ceff4dd)Diff
    FirebaseMessaging.java74.45%73.57%-0.88%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XKAEH0CGbT.html

firebase-crashlytics/CHANGELOG.md Outdated Show resolved Hide resolved
firebase-firestore/CHANGELOG.md Outdated Show resolved Hide resolved
firebase-inappmessaging-display/CHANGELOG.md Outdated Show resolved Hide resolved
firebase-inappmessaging/CHANGELOG.md Outdated Show resolved Hide resolved
@rlazo rlazo merged commit 43eec0e into master Sep 15, 2023
159 of 167 checks passed
@rlazo rlazo deleted the fix_m137_release branch September 15, 2023 14:16
rlazo added a commit that referenced this pull request Sep 15, 2023
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: rachelsaunders <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants