-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Filter equals method. #5210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 24.7.0 {: #firestore_v24-7-0}
* {{feature}} Expose MultiDb support in API. GitHub [#4015](//github.com/firebase/firebase-android-sdk/issues/4015){: .external}
* {{fixed}} Fixed a thread interference issue that may lead to a ConcurrentModificationException.
(GitHub [#5091](//github.com/firebase/firebase-android-sdk/issues/5091){: .external})
* {{fixed}} Implement equals method on Filter class. GitHub [#5210](//github.com/firebase/firebase-android-sdk/issues/5210){: .external}
#### {{firestore}} Kotlin extensions version 24.7.0 {: #firestore-ktx_v24-7-0}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates. |
tom-andersen
changed the title
Implement filter equals method.
Implement Filter equals method.
Jul 27, 2023
Coverage Report 1Affected Products
Test Logs |
ehsannas
reviewed
Jul 27, 2023
firebase-firestore/src/test/java/com/google/firebase/firestore/FilterTest.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/FilterTest.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/FilterTest.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/test/java/com/google/firebase/firestore/FilterTest.java
Outdated
Show resolved
Hide resolved
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
ehsannas
approved these changes
Jul 28, 2023
davidmotson
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Implement filter equals method. * Add changelog entry * Fix format and PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.