Added api for removing dismiss listener. #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html 2023-01-04 20:10:33.533757836 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html 2023-01-04 20:09:14.593211698 +0000
@@ -131,6 +131,13 @@
<tr>
<td width="40%"><code>void</code></td>
<td>
+ <div><code><a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a> dismissListener<br>)</code></div>
+ <p>Unregisters a dismiss listener.</p>
+ </td>
+ </tr>
+ <tr>
+ <td width="40%"><code>void</code></td>
+ <td>
<div><code><a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDisplayErrorListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayErrorListener)">removeDisplayErrorListener</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessagingDisplayErrorListener.html">FirebaseInAppMessagingDisplayErrorListener</a> displayErrorListener<br>)</code></div>
<p>Unregisters a display error listener.</p>
</td>
@@ -429,6 +436,28 @@
</tr>
</tbody>
</table>
+ </div>
+ </div>
+ <div><a name="removeDismissListener-com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener-"></a><a name="removedismisslistener"></a>
+ <h3 class="api-name" id="removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</h3>
+ <pre class="api-signature no-pretty-print">public void <a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a> dismissListener<br>)</pre>
+ <p>Unregisters a dismiss listener.</p>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a> dismissListener</code></td>
+ <td>
+ <p>the listener callback to be removed which was added using addDismissListener</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
</div>
</div>
<div><a name="removeDisplayErrorListener-com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayErrorListener-"></a><a name="removedisplayerrorlistener"></a>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html 2023-01-04 20:10:33.557758010 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html 2023-01-04 20:09:14.645212198 +0000
@@ -131,6 +131,13 @@
<tr>
<td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
<td>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</a>(<br> dismissListener: <a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a><br>)</code></div>
+ <p>Unregisters a dismiss listener.</p>
+ </td>
+ </tr>
+ <tr>
+ <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
+ <td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDisplayErrorListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayErrorListener)">removeDisplayErrorListener</a>(<br> displayErrorListener: <a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessagingDisplayErrorListener.html">FirebaseInAppMessagingDisplayErrorListener</a><br>)</code></div>
<p>Unregisters a display error listener.</p>
</td>
@@ -429,6 +436,28 @@
</tr>
</tbody>
</table>
+ </div>
+ </div>
+ <div><a name="removeDismissListener-com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener-"></a><a name="removedismisslistener"></a>
+ <h3 class="api-name" id="removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</h3>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessaging.html#removeDismissListener(com.google.firebase.inappmessaging.FirebaseInAppMessagingDismissListener)">removeDismissListener</a>(<br> dismissListener: <a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a><br>): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
+ <p>Unregisters a dismiss listener.</p>
+ <div class="devsite-table-wrapper">
+ <table class="responsive">
+ <thead>
+ <tr>
+ <th colspan="100%">Parameters</th>
+ </tr>
+ </thead>
+ <tbody class="list">
+ <tr>
+ <td width="40%"><code>dismissListener: <a href="/docs/reference/kotlin/com/google/firebase/inappmessaging/FirebaseInAppMessagingDismissListener.html">FirebaseInAppMessagingDismissListener</a></code></td>
+ <td>
+ <p>the listener callback to be removed which was added using addDismissListener</p>
+ </td>
+ </tr>
+ </tbody>
+ </table>
</div>
</div>
<div><a name="removeDisplayErrorListener-com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayErrorListener-"></a><a name="removedisplayerrorlistener"></a> |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
rlazo
reviewed
Jan 2, 2023
...-inappmessaging/src/main/java/com/google/firebase/inappmessaging/FirebaseInAppMessaging.java
Outdated
Show resolved
Hide resolved
...ging/src/main/java/com/google/firebase/inappmessaging/internal/DeveloperListenerManager.java
Show resolved
Hide resolved
|
The public api surface has changed for the subproject firebase-inappmessaging: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-inappmessaging: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-inappmessaging: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
Don't forget to update your and update the SDK |
|
Done..Please check the version update is correct. Thanks. |
rlazo
approved these changes
Jan 4, 2023
mrober
pushed a commit
that referenced
this pull request
Jan 30, 2023
Added api for removing dismiss listener.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added api for removing dismiss listener.
Motivational PR: #3980
Approved API Review: b/262402247