Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AppCheckProviders with Firebase Components. #4436

Merged
merged 5 commits into from
Dec 12, 2022

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Dec 8, 2022

Integrate SafetyNetAppCheckProvider, PlayIntegrityAppCheckProvider, and DebugAppCheckProvider with Firebase Components. This is a prerequisite for migrating the firebase-appcheck-safetynet, firebase-appcheck-playintegrity, and the firebase-appcheck-debug SDKs to use go/firebase-android-executors.

Note: This PR involves a refactor in the logic for initializing a DebugAppCheckProvider with a debug secret obtained from InstrumentationRegistry arguments, in order to integrate DebugAppCheckProvider with Firebase Components.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2022

Coverage Report 1

Affected Products

  • firebase-appcheck-debug

    Overall coverage changed from 77.27% (e05db82) to 78.08% (949d70e) by +0.81%.

    FilenameBase (e05db82)Merge (949d70e)Diff
    DebugAppCheckProvider.java77.50%72.09%-5.41%
    DebugAppCheckProviderFactory.java55.56%66.67%+11.11%
    FirebaseAppCheckDebugRegistrar.java0.00%75.00%+75.00%
    InternalDebugSecretProvider.java?0.00%?
  • firebase-appcheck-debug-testing

    Overall coverage changed from 76.00% (e05db82) to 88.46% (949d70e) by +12.46%.

    FilenameBase (e05db82)Merge (949d70e)Diff
    DebugAppCheckTestHelper.java78.26%82.35%+4.09%
    DebugSecretProvider.java?100.00%?
    FirebaseAppCheckDebugTestingRegistrar.java?100.00%?
  • firebase-appcheck-playintegrity

    Overall coverage changed from 88.89% (e05db82) to 91.43% (949d70e) by +2.54%.

    FilenameBase (e05db82)Merge (949d70e)Diff
    FirebaseAppCheckPlayIntegrityRegistrar.java0.00%88.89%+88.89%
  • firebase-appcheck-safetynet

    Overall coverage changed from 81.08% (e05db82) to 85.00% (949d70e) by +3.92%.

    FilenameBase (e05db82)Merge (949d70e)Diff
    FirebaseAppCheckSafetyNetRegistrar.java0.00%100.00%+100.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qaKm16mXis.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Unit Test Results

17 files   -    381  17 suites   - 381   37s ⏱️ - 17m 41s
39 tests  - 4 713  39 ✔️  - 4 691  0 💤  - 22  0 ±0 
39 runs   - 4 729  39 ✔️  - 4 707  0 💤  - 22  0 ±0 

Results for commit 4c7d4a9. ± Comparison against base commit fa88eee.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2022

Size Report 1

Affected Products

  • firebase-appcheck-debug

    TypeBase (e05db82)Merge (949d70e)Diff
    aar9.93 kB10.9 kB+975 B (+9.8%)
    apk (aggressive)341 kB342 kB+876 B (+0.3%)
    apk (release)999 kB999 kB+196 B (+0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (e05db82)Merge (949d70e)Diff
    aar6.26 kB7.27 kB+1.01 kB (+16.1%)
    apk (aggressive)347 kB348 kB+1.32 kB (+0.4%)
    apk (release)1.04 MB1.04 MB+352 B (+0.0%)
  • firebase-appcheck-playintegrity

    TypeBase (e05db82)Merge (949d70e)Diff
    aar10.2 kB10.7 kB+589 B (+5.8%)
    apk (aggressive)341 kB344 kB+3.04 kB (+0.9%)
    apk (release)1.01 MB1.01 MB+220 B (+0.0%)
  • firebase-appcheck-safetynet

    TypeBase (e05db82)Merge (949d70e)Diff
    aar9.65 kB10.2 kB+581 B (+6.0%)
    apk (aggressive)341 kB347 kB+5.89 kB (+1.7%)
    apk (release)1.01 MB1.01 MB+68 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Rhy5TJZlN1.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 8, 2022

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-app-check

    DeviceStatisticsDistributions
    oriole-32
    Percentilee05db82949d70eDiffSignificant (?)
    p10417 ±457 μs507 ±490 μs+90.3 μs (+21.7%)NO
    p25434 ±466 μs528 ±492 μs+94.5 μs (+21.8%)NO
    p50466 ±486 μs581 ±501 μs+116 μs (+24.8%)NO
    p75515 ±498 μs647 ±530 μs+132 μs (+25.6%)NO
    p90605 ±567 μs765 ±603 μs+160 μs (+26.4%)NO

    20 test runs in comparison
    CommitTest Runs
    e05db82
    • 2022-12-09_15:28:23.595810_wKpZ
    • 2022-12-09_15:28:23.601991_hmLJ
    • 2022-12-09_15:28:23.602002_PsDy
    • 2022-12-09_15:28:23.602009_rLDl
    • 2022-12-09_15:28:23.602014_YZnJ
    • 2022-12-09_15:28:23.602019_fzKy
    • 2022-12-09_15:28:23.602024_MmKG
    • 2022-12-09_15:28:23.602029_llRz
    • 2022-12-09_15:28:23.602034_nZqD
    • 2022-12-09_15:28:23.602042_jcUW
    949d70e
    • 2022-12-12_21:18:08.852975_fGIa
    • 2022-12-12_21:18:08.865075_dfzj
    • 2022-12-12_21:18:08.865108_EcDV
    • 2022-12-12_21:18:08.865525_sOzY
    • 2022-12-12_21:18:08.865536_DpDZ
    • 2022-12-12_21:18:08.865543_jtdU
    • 2022-12-12_21:18:08.865776_qjnW
    • 2022-12-12_21:18:08.865790_DEqZ
    • 2022-12-12_21:18:08.865796_eosk
    • 2022-12-12_21:18:08.865809_pNqC
    redfin-30
    Percentilee05db82949d70eDiffSignificant (?)
    p101.74 ±2 ms1.62 ±2 ms-116 μs (-6.7%)NO
    p251.89 ±2 ms1.74 ±2 ms-150 μs (-8.0%)NO
    p502.12 ±2 ms1.97 ±2 ms-156 μs (-7.3%)NO
    p752.45 ±3 ms2.30 ±3 ms-150 μs (-6.1%)NO
    p903.01 ±3 ms2.85 ±3 ms-162 μs (-5.4%)NO

    20 test runs in comparison
    CommitTest Runs
    e05db82
    • 2022-12-09_15:28:23.595810_wKpZ
    • 2022-12-09_15:28:23.601991_hmLJ
    • 2022-12-09_15:28:23.602002_PsDy
    • 2022-12-09_15:28:23.602009_rLDl
    • 2022-12-09_15:28:23.602014_YZnJ
    • 2022-12-09_15:28:23.602019_fzKy
    • 2022-12-09_15:28:23.602024_MmKG
    • 2022-12-09_15:28:23.602029_llRz
    • 2022-12-09_15:28:23.602034_nZqD
    • 2022-12-09_15:28:23.602042_jcUW
    949d70e
    • 2022-12-12_21:18:08.852975_fGIa
    • 2022-12-12_21:18:08.865075_dfzj
    • 2022-12-12_21:18:08.865108_EcDV
    • 2022-12-12_21:18:08.865525_sOzY
    • 2022-12-12_21:18:08.865536_DpDZ
    • 2022-12-12_21:18:08.865543_jtdU
    • 2022-12-12_21:18:08.865776_qjnW
    • 2022-12-12_21:18:08.865790_DEqZ
    • 2022-12-12_21:18:08.865796_eosk
    • 2022-12-12_21:18:08.865809_pNqC
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilee05db82949d70eDiffSignificant (?)
    p10188 ±3 ms192 ±4 ms+4.59 ms (+2.4%)NO
    p25194 ±4 ms199 ±5 ms+4.97 ms (+2.6%)NO
    p50202 ±4 ms206 ±5 ms+4.32 ms (+2.1%)NO
    p75209 ±4 ms215 ±5 ms+5.74 ms (+2.7%)NO
    p90218 ±4 ms227 ±9 ms+8.60 ms (+3.9%)NO

    20 test runs in comparison
    CommitTest Runs
    e05db82
    • 2022-12-09_15:28:23.595810_wKpZ
    • 2022-12-09_15:28:23.601991_hmLJ
    • 2022-12-09_15:28:23.602002_PsDy
    • 2022-12-09_15:28:23.602009_rLDl
    • 2022-12-09_15:28:23.602014_YZnJ
    • 2022-12-09_15:28:23.602019_fzKy
    • 2022-12-09_15:28:23.602024_MmKG
    • 2022-12-09_15:28:23.602029_llRz
    • 2022-12-09_15:28:23.602034_nZqD
    • 2022-12-09_15:28:23.602042_jcUW
    949d70e
    • 2022-12-12_21:18:08.852975_fGIa
    • 2022-12-12_21:18:08.865075_dfzj
    • 2022-12-12_21:18:08.865108_EcDV
    • 2022-12-12_21:18:08.865525_sOzY
    • 2022-12-12_21:18:08.865536_DpDZ
    • 2022-12-12_21:18:08.865543_jtdU
    • 2022-12-12_21:18:08.865776_qjnW
    • 2022-12-12_21:18:08.865790_DEqZ
    • 2022-12-12_21:18:08.865796_eosk
    • 2022-12-12_21:18:08.865809_pNqC
    redfin-30
    Percentilee05db82949d70eDiffSignificant (?)
    p10225 ±6 ms250 ±9 ms+24.8 ms (+11.0%)NO
    p25231 ±6 ms257 ±11 ms+26.6 ms (+11.5%)NO
    p50238 ±6 ms265 ±13 ms+27.4 ms (+11.5%)NO
    p75246 ±6 ms274 ±14 ms+28.2 ms (+11.5%)NO
    p90256 ±8 ms286 ±15 ms+30.4 ms (+11.9%)NO

    20 test runs in comparison
    CommitTest Runs
    e05db82
    • 2022-12-09_15:28:23.595810_wKpZ
    • 2022-12-09_15:28:23.601991_hmLJ
    • 2022-12-09_15:28:23.602002_PsDy
    • 2022-12-09_15:28:23.602009_rLDl
    • 2022-12-09_15:28:23.602014_YZnJ
    • 2022-12-09_15:28:23.602019_fzKy
    • 2022-12-09_15:28:23.602024_MmKG
    • 2022-12-09_15:28:23.602029_llRz
    • 2022-12-09_15:28:23.602034_nZqD
    • 2022-12-09_15:28:23.602042_jcUW
    949d70e
    • 2022-12-12_21:18:08.852975_fGIa
    • 2022-12-12_21:18:08.865075_dfzj
    • 2022-12-12_21:18:08.865108_EcDV
    • 2022-12-12_21:18:08.865525_sOzY
    • 2022-12-12_21:18:08.865536_DpDZ
    • 2022-12-12_21:18:08.865543_jtdU
    • 2022-12-12_21:18:08.865776_qjnW
    • 2022-12-12_21:18:08.865790_DEqZ
    • 2022-12-12_21:18:08.865796_eosk
    • 2022-12-12_21:18:08.865809_pNqC

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/H9nFVaI8iH/index.html

@rosalyntan rosalyntan changed the title Integrate SafetyNetAppCheckProvider with Firebase Components. Integrate AppCheckProviders with Firebase Components. Dec 10, 2022
@rosalyntan rosalyntan merged commit 66c7398 into master Dec 12, 2022
@rosalyntan rosalyntan deleted the rosalyntan.components branch December 12, 2022 21:29
danasilver added a commit that referenced this pull request Dec 22, 2022
* return exception if modelname is empty (#4226)

* Add "create release PR" github action (#4236)

This implementation:

- Creates the base branch (name is based in user input)
- Creates the release branch (name is based in user input)
- Creates the release.cfg file in the release branch without adding
  any SDK (module) to it.

It can create the branches based on any existing branch of the repo.

* Sync spec tests from web SDK to Android SDK (#4230)

* Update versions (#4238)

* Update versions

* Exclude .github dir from `firebaseContinuousIntegration` paths (#4239)

* Performing IN expansion (#4221)

* WIP: `in` expansion.

* Add composite filter in-expansion test.

* Fix formatting.

* Run in-expansion as part of DNF computation and add tests.

* Add test with nested IN filters with CSI.

* Add tests for other cases.

* typo fix (#4237)

* Firestore: Add test that verifies count query error message when missing index (#4232)

* refactor(functions): update firebase-iid to 21.1.0 (#4225)

* refactor(functions): update firebase-iid to 21.1.0

* Update CHANGELOG.md

* Update CHANGELOG.md

* bump firebase-iid-interop to 17.1.0

* exclude firebase-components from firebase-iid dependency

* Fix Firestore failing to return empty results from the local cache (#4207)

* Remove plexus-utils from firebase-database's test dependency (#4233)

firebase-database only uses StringUtils#repeat in test code, and it is
easy to port repeat method to test file and remove plexus-utils
from test dependency.

Signed-off-by: utzcoz <[email protected]>

Signed-off-by: utzcoz <[email protected]>

* test(functions): fix instrumentation tests (#4249)

* test(functions): fix instrumentation tests

* fix java format

* Fix flakiness in MessagingAnalyticsRoboTest.java (#4259)

Properly reset SharedPreferences test state in between each test.

* Update CHANGELOG entries across several sdks (#4240)

* Fix FAILED_PRECONDITION when writing to a deleted document in a transaction (#4257)

* Fix Javadoc link generation in Dackka (#4258)

* Remove redundant package list

* Implement fix for link transformations

* Set reference path in DackkaPlugin

* Removed accidental dackka diff script

* Remove GenericTypeIndicator in error messages (#4268)

* Early return in getDocumentsMatchingTarget (#4272)

* Early return in getDocumentsMatchingTarget

* Address Feedback

* Upgrade GRPC tp 1.50.2 (#4277)

* Upgrade GRPC tp 1.50.2

* Add changelog for Upgrade GRPC tp 1.50.2

* Add links to changelog

* Add Dackka transform to remove leading groupId in Javadocs (#4278)

* Add groupId removal transform

* Add bug link for dackka exposing the configuration

* Add @CanIgnoreReturnValue to MockInputStreamHelper.injectExceptionAt(int) (#4275)

* Remove `@Deprecated` annotations. (#4289)

* Fix FrameMetrics NPE (#4284)

* Initial version of the build release artifacts workflow. (#4287)

* Initial version of the build release artifacts workflow.

This version of the workflow hardcodes the list of sdks to release to
include Firestore only. Also, generated javadoc is not yet equivalent
to what's generated by the regular release process.

* Prepend 'releases/' to the name of the release branches (#4291)

This will make it easier to identify them and apply restrictions on them.

* Add androidx.annotation package (#4286)

* Add support of macrobenchmark result analysis in fireci (#4285)

* Fix broken code elements in docs (#4292)

* Fix code blocks

* Fix linting in firebase-database

* Fix FirebaseMLDownloader linting

* [Fireperf][AASA] Additional experiments for `_experiment_as_ttid` (#4283)

* predraw and uptimeMillis

* fix send event

* fix dangling variable and naming

* copyright

* fix test

* onStop

* test

* better readability

* comments

* reduce code

* reset

* Deflake `AppStateMonitorTest` (#4294)

* fix flaky test

* word smithing

* Add executor documentation (#4298)

* Wrap &lt and &gt symbols in code blocks (#4299)

* Add action to show a message when merging to the main branch (#4301)

* Add action to show a message when merging to the main branch

* Fail if label 'merge-main-ack' is not present

* Fix multiline hyperlink renders (#4307)

* Replace trace hyperlink with direct link

* Replace timestamp link with non multiline variant

* Add transform to rectify hyperlink bugs in see blocks

* Fix ndk build. (#4311)

* Fix ndk build.

Due to AGP upgrade the crashlytics-trampoline.so file stopped being
included in the resulting AAR, this causes issues on devices with api
29+.

* fix filename

* Revert "Add support of macrobenchmark result analysis in fireci (#4285)" (#4312)

This reverts commit 00d8c72.

* Update executors.md (#4306)

* Switch from ktlint to ktfmt (#4318)

Additionally upgrade google-java-format to latest version.

* Merge executors to master (#4322)

* Add qualifier support to firebase components. (#3180)

* Add qualifier support to firebase components.

Details: go/firebase-component-qualifiers

* fix errorprone error.

* change copyright year.

* Register executors as components. (#4288)

* Register executors as components.

The intent for those is to be used by all Firebase SDKs and forbid
creating their own at will.

* Add copyrights.

* add more copyrights

* ktlintformat

* gJF

* ktlint

* Address review comments.

* Adds generally useful executors (#4305)

Namely, SequentialExecutor and directExecutor.

* Enable strict mode for executors. (#4303)

Any violations would kill the app in debug builds of firebase-common,
and log a warning in release builds. This is done to fail tests that
incorrectly use executors while not affecting 3p apps in release builds.

Additionally correctly set thread priorities in an Android specific way.

* Enable thread pool linter check. (#4297)

* Enable thread pool linter check.

All violations are now suppressed, bugs filed to fix each product.

* ktlint

* Remove init

* Fix copyright

* Replace Doclava with Dackka (#4324)

* Remove restriction on Dackka's Javadoc

* Refactor release plugin to use dackka

* Add support of macrobenchmark result analysis in fireci (#4323)

* Avoid throwing in ForcedSender.sendBlocking (#4293)

* Make ForcedSender.sendBlocking do nothing, instead of throw, when given a wrong Transport type.

This will make it easier to mock Transport in tests. This method is best-effort anyway, so doing nothing instead of throwing is fine.

* Log warning when given wrong type.

* Fix deadlock when handling simultaneous messages. (#4327)

#4315
* Released sendWakefulServiceIntent()'s WakeLock on the main thread instead of within WithinAppServiceConnection to prevent a deadlock trying to acquire the WakeLockHolder.syncObject.

* Update build-release-artifacts.yml (#4354)

Remove unnecessary zip extension

* Improve fireci CLI for macrobenchmark (#4359)

- Output more analysis results
- Close figure after saving to file
- Switch to `redfin` for more consistent results

* Fix warnings in the linter. (#4360)

* Add action to create bom (#4352)

* Add action to create bom

* Use ubuntu-latest

* Update versions and changelogs (#4343)

* Update versions

* Update changelogs

* Update functions changelog

* Update firestore changelog

* update fireperf changelog

* update messaging changelog

* Migrate functions off of UI thread for continuations. (#4364)

* Migrate functions off of UI thread for continuations.

* fixes

* Add changelog

* fix

* fix dep

* Enable dead code elimination for vendored deps. (#4368)

* Set jvm target for kotlin to jvm11 to match java. (#4369)

* Set jvm target for kotlin to jvm11 to match java.

* Fix typo

* Changed protobuf-java to latest version 3.21.9 (#4373)

* Changed protoc and protobuf-java to latest version 3.21.9

* changed protoc version back and only target protobuf-java

* Use dagger in functions. (#4366)

This simplifies injection of firebase components so they don't have to be passed all the way from the registrar into classes that actually use components.

This change adds `+4.22 kB` to the size of the sdk, but is a small enough increase compared to the advantages it provides

* Migrate fireperf content provider to component (#4242)

* Migrate fireperf content provider to component

* Resolve comments

* Collect startup time from init provider

* Limit startup time usage to during init provider initialization

* Pass in startup time in private constructor

* Component dependencies and names

* Ensure FirebasePerfEarly gets initialized before FirebasePerf

* Actually fix merge

* Adjust tests

* Resolve cli tests

* Resolve nullability

* Actually resolving nullability lints

* Formatting

* Adjust privacy and docs

* Hide startup time in the init provider

* Fix error with getting optional component from ComponentContainer

* Fix error with getting optional component from ComponentContainer

* Hide one more method

* Migrate ml to dagger DI. (#4370)

This simplifies injection of firebase components so they don't have to be passed all the way from the registrar into classes that actually use components.

This change adds `+6.58 kB` to the size of the sdk, but is a small enough increase compared to the advantages it provides

* Add examples for new Flow operators in firestore-ktx (#4078)

* Set ndkVersion for Crashlytics NDK SDK. (#4310)

* Remove custom NDK installations (#4378)

* Add documentation, and address/remove some TODOs. (#4274)

* Fix ci tests presubmit to work on all branches. (#4381)

* Add lint check that detects UI thread continuations. (#4363)

* Add lint check that detects UI thread continuations.

* Suppress lint failures pending actual fixes by product teams.

* Fix copyrights (#4386)

* Forbid creating ui thread Handler. (#4385)

* Forbid creating ui thread Handler.

* fix perf tests

* ktfmt

* actually fix perf

* Add workflow triggers for startup time test (#4379)

* Enable for Kotlin Gradle dsl. (#4392)

* Enable for Kotlin Gradle dsl.

Additionally migrate to using a version catalog to simplify dependency
management.

* Fix metalava

* Address review comments

* Migrate RC to common executors. (#4393)

* Allow task subclasses to implement overloads. (#4394)

* Remove unused Executor classes. (#4383)

* Invoke async api for processing startup time request (#4406)

* Upgrade JaCoCo plugin version (#4423)

Fixes the issue where JaCoCo cannot produce coverage files for certain kotlin packages.

See details:
- jacoco/jacoco#1155
- https://youtrack.jetbrains.com/issue/KT-44757

* Refine startup time test app (#4407)

- Force initialize all components
- Include `fire-perf-early` in measurements
- Test only changed products in pull requests

* Initial setup for Github Pages (#4427)

* Add Component documentation (#4429)

* Add components documentation

* switch to light theme

* undo workflow change

* remove direct boot mode reference

* Create scorecards.yml

* Change concurrency group for health metrics test to "github.sha" (#4428)

The problem with "github.ref" was that when two consecutive
commits are pushed to a feature branch (e.g. `master`) around
the same time, the execution of health metrics test for the
second commit will cancel the execution for the first one, and
thus make the metrics measurement for the first commit unavailable.

* Port app.get() check from errorprone to lint (#4434)

* Port app.get() check from errorprone to lint

Motivation: Make sure the check works for kotlin, not only java.

* Add copyrights

* Added more docs (#4437)

* Describe dependencies

* deploy

* fix typo

* fixes

* updates

* toc

* fix

* updates

* configure callouts

* undo deploy from branch

* Apply suggestions from code review

Co-authored-by: Rodrigo Lazo <[email protected]>

Co-authored-by: Rodrigo Lazo <[email protected]>

* Migrate `firebase-appcheck` to use standard executors provided by Firebase Common. (#4431)

* Migrate to use standard executors provided by Firebase Common.

* Update changelog and fix unit test.

* Address review comments.

* Fix unit test.

* Address review comments.

* Fix RC Executor annotation (#4395)

* Integrate `AppCheckProvider`s with Firebase Components. (#4436)

* Integrate `SafetyNetAppCheckProvider` with Firebase Components.

* Suppress warning.

* Integrate DebugAppCheckProvider with Firebase Components.

* Add unit tests for the new registrars.

* Integrate `PlayIntegrityAppCheckProvider` with Firebase Components.

* Add dependency injection docs (#4447)

* Migrate firebase-inappmessaging SDK to go/firebase-android-executors. (#4440)

Migrate firebase-inappmessaging SDK to go/firebase-android-executors.

* Migrate remaining App Check SDKs to go/firebase-android-executors. (#4449)

* Migrate `firebase-appcheck-safetynet` to go/firebase-android-executors.

* Migrate `firebase-appcheck-playintegrity` to go/firebase-android-executors.

* Migrate `firebase-appcheck-debug` to go/firebase-android-executors.

* Remove unnecessary class field from `SafetyNetAppCheckProvider`.

* Update changelogs.

* Migrate core libraries to Gradle Kotlin DSL. (#4452)

* Migrate core libraries to Gradle Kotlin DSL.

* update

* Add functions, fix tests

* fix docs

* fix functions ktx minSdk version.

* Apply suggestions from code review

Co-authored-by: Rodrigo Lazo <[email protected]>

Co-authored-by: Rodrigo Lazo <[email protected]>

* Fix overlay bug leas to patch mutation optimization not being applied (#4442)

* Fix overlay patch bug

* Feedback

* Delete comment

* Add Diff Javadoc workflow (#4426)

* Add diff javadoc workflow

* Minor tweaks

* Revert checkout order change

* Revert incorrect changes

* Modify ChangedModulesTask

* Only compare modified SDKs

* Change build order

* Add fetch depth

* Fix typo

* Only Firebase SDKs

* Move continuations off main thread for App Check SDKs. (#4453)

* Move continuations off main thread for `firebase-appcheck`.

* One more continuation in `firebase-appcheck`.

* Move continuations off main thread for `firebase-appcheck-debug`.

* Rearrange executor order.

* Move continuations off main thread for `firebase-appcheck-safetynet`.

* Move continuations off main thread for `firebase-appcheck-playintegrity`.

* Update changelog.

* Fix `SafetyNetAppCheckProviderTest`.

* Address review comments.

* update mlkitdownloader to use executors (#4382)

* update dagger

* update

* update

* update

* update registrar

* update tests

* Replace tag targets with commits (#4460)

* Fix typo in comments. (#4462)

* Use Firebase executors for realtime.

* Format java.

Signed-off-by: utzcoz <[email protected]>
Co-authored-by: argzdev <[email protected]>
Co-authored-by: Rodrigo Lazo <[email protected]>
Co-authored-by: Mila <[email protected]>
Co-authored-by: Ehsan <[email protected]>
Co-authored-by: cherylEnkidu <[email protected]>
Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: Rosário Pereira Fernandes <[email protected]>
Co-authored-by: utzcoz <[email protected]>
Co-authored-by: William Xu <[email protected]>
Co-authored-by: Daymon <[email protected]>
Co-authored-by: Tom Andersen <[email protected]>
Co-authored-by: Kurt Alfred Kluever <[email protected]>
Co-authored-by: Rosalyn Tan <[email protected]>
Co-authored-by: Leo Zhan <[email protected]>
Co-authored-by: Yifan Yang <[email protected]>
Co-authored-by: Vladimir Kryachko <[email protected]>
Co-authored-by: Matthew Robertson <[email protected]>
Co-authored-by: Greg Sakakihara <[email protected]>
Co-authored-by: emilypgoogle <[email protected]>
Co-authored-by: Márton Braun <[email protected]>
Co-authored-by: Eldhose M Babu <[email protected]>
Co-authored-by: wu-hui <[email protected]>
Co-authored-by: Vinay Guthal <[email protected]>
@firebase firebase locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants