Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some query restrictions and add integration tests #4231

Merged
merged 12 commits into from
Feb 15, 2023
Merged

Remove some query restrictions and add integration tests #4231

merged 12 commits into from
Feb 15, 2023

Conversation

ehsannas
Copy link
Contributor

This PR actually removes the restrictions and adds integration tests (which are expected to fail at this time).

@ehsannas ehsannas mentioned this pull request Oct 21, 2022
Merged
@ehsannas ehsannas requested a review from wu-hui October 21, 2022 23:29
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 21, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from ? (6071e9d) to 44.15% (33dd98a) by ?.

    315 individual files with coverage change

    FilenameBase (6071e9d)Merge (33dd98a)Diff
    AbstractStream.java?34.81%?
    ActivityScope.java?0.00%?
    AggregateQuery.java?15.00%?
    AggregateQuerySnapshot.java?0.00%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    AndroidConnectivityMonitor.java?39.51%?
    ApiUtil.java?12.50%?
    ArrayContainsAnyFilter.java?100.00%?
    ArrayContainsFilter.java?100.00%?
    ArrayTransformOperation.java?86.49%?
    ArrayValue.java?48.60%?
    ArrayValueOrBuilder.java?0.00%?
    Assert.java?60.00%?
    AsyncEventListener.java?0.00%?
    AsyncQueue.java?70.65%?
    AutoValue_FieldIndex.java?58.33%?
    AutoValue_FieldIndex_IndexOffset.java?58.62%?
    AutoValue_FieldIndex_IndexState.java?59.09%?
    AutoValue_FieldIndex_Segment.java?54.17%?
    AutoValue_IndexEntry.java?34.21%?
    AutoValue_Overlay.java?54.55%?
    BackgroundQueue.java?81.25%?
    BasePath.java?86.54%?
    BatchGetDocumentsRequest.java?0.00%?
    BatchGetDocumentsRequestOrBuilder.java?0.00%?
    BatchGetDocumentsResponse.java?0.00%?
    BatchGetDocumentsResponseOrBuilder.java?0.00%?
    BeginTransactionRequest.java?0.00%?
    BeginTransactionRequestOrBuilder.java?0.00%?
    BeginTransactionResponse.java?0.00%?
    BeginTransactionResponseOrBuilder.java?0.00%?
    Blob.java?76.92%?
    Bound.java?39.29%?
    BundleCache.java?0.00%?
    BundleCallback.java?0.00%?
    BundledDocumentMetadata.java?0.00%?
    BundledDocumentMetadataOrBuilder.java?0.00%?
    BundleDocument.java?90.00%?
    BundledQuery.java?34.57%?
    BundledQueryOrBuilder.java?0.00%?
    BundleElement.java?0.00%?
    BundleElementOrBuilder.java?0.00%?
    BundleLoader.java?100.00%?
    BundleMetadata.java?0.00%?
    BundleMetadataOrBuilder.java?0.00%?
    BundleProto.java?0.00%?
    BundleReader.java?95.29%?
    BundleSerializer.java?89.47%?
    ByteBufferInputStream.java?83.33%?
    CollectionReference.java?13.64%?
    CommitRequest.java?0.00%?
    CommitRequestOrBuilder.java?0.00%?
    CommitResponse.java?0.00%?
    CommitResponseOrBuilder.java?0.00%?
    CommonProto.java?0.00%?
    ComponentProvider.java?100.00%?
    CompositeFilter.java?98.57%?
    ConnectivityMonitor.java?0.00%?
    Consumer.java?0.00%?
    CreateDocumentRequest.java?0.00%?
    CreateDocumentRequestOrBuilder.java?0.00%?
    CredentialsProvider.java?100.00%?
    Cursor.java?35.29%?
    CursorOrBuilder.java?0.00%?
    CustomClassMapper.java?84.25%?
    DatabaseId.java?70.37%?
    DatabaseInfo.java?90.91%?
    Datastore.java?23.28%?
    DatastoreTestTrace.java?0.00%?
    DeleteDocumentRequest.java?0.00%?
    DeleteDocumentRequestOrBuilder.java?0.00%?
    DeleteMutation.java?95.24%?
    DirectionalIndexByteEncoder.java?100.00%?
    Document.java?100.00%?
    DocumentChange.java?67.61%?
    DocumentChangeOrBuilder.java?0.00%?
    DocumentCollections.java?83.33%?
    DocumentDelete.java?34.62%?
    DocumentDeleteOrBuilder.java?0.00%?
    DocumentId.java?0.00%?
    DocumentKey.java?97.14%?
    DocumentMask.java?40.66%?
    DocumentMaskOrBuilder.java?0.00%?
    DocumentOrBuilder.java?0.00%?
    DocumentOverlayCache.java?0.00%?
    DocumentProto.java?0.00%?
    DocumentReference.java?13.24%?
    DocumentRemove.java?29.23%?
    DocumentRemoveOrBuilder.java?0.00%?
    DocumentSet.java?83.78%?
    DocumentSnapshot.java?37.50%?
    DocumentTransform.java?29.31%?
    DocumentTransformOrBuilder.java?0.00%?
    DocumentViewChange.java?90.91%?
    DocumentViewChangeSet.java?87.88%?
    EncodedPath.java?93.22%?
    EventListener.java?0.00%?
    EventManager.java?96.15%?
    Exclude.java?0.00%?
    Executors.java?100.00%?
    ExistenceFilter.java?80.00%?
    ExistenceFilterOrBuilder.java?0.00%?
    ExponentialBackoff.java?30.43%?
    FieldFilter.java?93.06%?
    FieldIndex.java?98.18%?
    FieldMask.java?57.89%?
    FieldPath.java?89.66%?
    FieldTransform.java?64.71%?
    FieldValue.java?82.14%?
    FileUtil.java?0.00%?
    Filter.java?0.00%?
    FirebaseAppCheckTokenProvider.java?93.75%?
    FirebaseAuthCredentialsProvider.java?100.00%?
    FirebaseClientGrpcMetadataProvider.java?44.00%?
    FirebaseFirestore.java?36.67%?
    FirebaseFirestoreException.java?83.72%?
    FirebaseFirestoreSettings.java?75.00%?
    FirestoreCallCredentials.java?18.60%?
    FirestoreChannel.java?18.10%?
    FirestoreClient.java?36.11%?
    FirestoreGrpc.java?2.46%?
    FirestoreIndexValueWriter.java?77.11%?
    FirestoreMultiDbComponent.java?100.00%?
    FirestoreProto.java?0.00%?
    FirestoreRegistrar.java?100.00%?
    Function.java?0.00%?
    GeoPoint.java?91.67%?
    GetDocumentRequest.java?0.00%?
    GetDocumentRequestOrBuilder.java?0.00%?
    GrpcCallProvider.java?69.41%?
    GrpcMetadataProvider.java?0.00%?
    IgnoreExtraProperties.java?0.00%?
    IncomingStreamObserver.java?0.00%?
    Index.java?30.02%?
    IndexBackfiller.java?100.00%?
    IndexByteEncoder.java?88.57%?
    IndexEntry.java?100.00%?
    IndexManager.java?100.00%?
    IndexOrBuilder.java?0.00%?
    IndexProto.java?0.00%?
    InFilter.java?100.00%?
    IntMath.java?41.67%?
    KeyFieldFilter.java?66.67%?
    KeyFieldInFilter.java?0.00%?
    KeyFieldNotInFilter.java?0.00%?
    LimboDocumentChange.java?70.59%?
    ListCollectionIdsRequest.java?0.00%?
    ListCollectionIdsRequestOrBuilder.java?0.00%?
    ListCollectionIdsResponse.java?0.00%?
    ListCollectionIdsResponseOrBuilder.java?0.00%?
    ListDocumentsRequest.java?0.00%?
    ListDocumentsRequestOrBuilder.java?0.00%?
    ListDocumentsResponse.java?0.00%?
    ListDocumentsResponseOrBuilder.java?0.00%?
    Listener.java?0.00%?
    ListenerRegistration.java?0.00%?
    ListenerRegistrationImpl.java?0.00%?
    ListenRequest.java?10.66%?
    ListenRequestOrBuilder.java?0.00%?
    ListenResponse.java?32.64%?
    ListenResponseOrBuilder.java?0.00%?
    ListenSequence.java?100.00%?
    LoadBundleTask.java?25.26%?
    LoadBundleTaskProgress.java?60.47%?
    LocalDocumentsResult.java?100.00%?
    LocalDocumentsView.java?100.00%?
    LocalSerializer.java?97.35%?
    LocalStore.java?100.00%?
    LocalViewChanges.java?100.00%?
    Logger.java?75.00%?
    LogicUtils.java?96.67%?
    LruDelegate.java?0.00%?
    LruGarbageCollector.java?97.20%?
    MapValue.java?53.00%?
    MapValueOrBuilder.java?0.00%?
    MemoryBundleCache.java?100.00%?
    MemoryComponentProvider.java?100.00%?
    MemoryDocumentOverlayCache.java?100.00%?
    MemoryEagerReferenceDelegate.java?100.00%?
    MemoryIndexManager.java?68.97%?
    MemoryLruReferenceDelegate.java?96.00%?
    MemoryMutationQueue.java?98.57%?
    MemoryOverlayMigrationManager.java?100.00%?
    MemoryPersistence.java?100.00%?
    MemoryRemoteDocumentCache.java?98.28%?
    MemoryTargetCache.java?100.00%?
    MetadataChanges.java?100.00%?
    MutableDocument.java?100.00%?
    Mutation.java?100.00%?
    MutationBatch.java?89.23%?
    MutationBatchResult.java?100.00%?
    MutationQueue.java?0.00%?
    MutationResult.java?100.00%?
    NamedQuery.java?0.00%?
    NamedQueryOrBuilder.java?0.00%?
    NotInFilter.java?85.71%?
    NumberComparisonHelper.java?100.00%?
    NumericIncrementTransformOperation.java?87.50%?
    ObjectValue.java?99.06%?
    OnlineState.java?100.00%?
    OnlineStateTracker.java?98.11%?
    OnProgressListener.java?0.00%?
    OrderBy.java?96.55%?
    OrderedCodeWriter.java?68.52%?
    Overlay.java?100.00%?
    OverlayedDocument.java?100.00%?
    OverlayMigrationManager.java?0.00%?
    PatchMutation.java?100.00%?
    Persistence.java?100.00%?
    Precondition.java?37.82%?
    PreconditionOrBuilder.java?0.00%?
    Preconditions.java?57.89%?
    PropertyName.java?0.00%?
    Query.java?4.04%?
    QueryDocumentSnapshot.java?64.71%?
    QueryEngine.java?98.63%?
    QueryListener.java?100.00%?
    QueryProto.java?0.00%?
    QueryPurpose.java?100.00%?
    QueryResult.java?100.00%?
    QuerySnapshot.java?76.36%?
    QueryView.java?100.00%?
    ReferenceDelegate.java?0.00%?
    ReferenceSet.java?92.45%?
    RemoteDocumentCache.java?0.00%?
    RemoteEvent.java?92.31%?
    RemoteSerializer.java?84.63%?
    RemoteStore.java?88.49%?
    ResourcePath.java?94.74%?
    RollbackRequest.java?0.00%?
    RollbackRequestOrBuilder.java?0.00%?
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    RunQueryRequest.java?0.00%?
    RunQueryRequestOrBuilder.java?0.00%?
    RunQueryResponse.java?0.00%?
    RunQueryResponseOrBuilder.java?0.00%?
    Scheduler.java?0.00%?
    ServerTimestamp.java?0.00%?
    ServerTimestampOperation.java?100.00%?
    ServerTimestamps.java?79.17%?
    SetMutation.java?97.22%?
    SetOptions.java?0.00%?
    SnapshotMetadata.java?68.75%?
    SnapshotVersion.java?87.50%?
    Source.java?0.00%?
    SQLiteBundleCache.java?90.00%?
    SQLiteComponentProvider.java?100.00%?
    SQLiteDocumentOverlayCache.java?97.85%?
    SQLiteIndexManager.java?99.49%?
    SQLiteLruReferenceDelegate.java?98.67%?
    SQLiteMutationQueue.java?82.76%?
    SQLiteOverlayMigrationManager.java?90.48%?
    SQLitePersistence.java?86.34%?
    SQLiteRemoteDocumentCache.java?98.21%?
    SQLiteSchema.java?96.63%?
    SQLiteTargetCache.java?98.47%?
    Stream.java?100.00%?
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    StructuredQuery.java?32.54%?
    StructuredQueryOrBuilder.java?0.00%?
    Supplier.java?0.00%?
    SyncEngine.java?93.31%?
    Target.java?95.79%?
    TargetCache.java?0.00%?
    TargetChange.java?80.00%?
    TargetChangeOrBuilder.java?0.00%?
    TargetData.java?77.50%?
    TargetIdGenerator.java?100.00%?
    TargetIndexMatcher.java?100.00%?
    TargetOrBuilder.java?0.00%?
    TargetState.java?97.78%?
    ThrottledForwardingExecutor.java?100.00%?
    ThrowOnExtraProperties.java?0.00%?
    Timestamp.java?80.39%?
    Token.java?0.00%?
    Transaction.java?0.00%?
    TransactionOptions.java?0.00%?
    TransactionOptionsOrBuilder.java?0.00%?
    TransactionRunner.java?0.00%?
    TransformOperation.java?0.00%?
    UpdateDocumentRequest.java?0.00%?
    UpdateDocumentRequestOrBuilder.java?0.00%?
    User.java?78.57%?
    UserData.java?66.00%?
    UserDataReader.java?70.48%?
    UserDataWriter.java?51.02%?
    Util.java?67.63%?
    Value.java?40.97%?
    ValueOrBuilder.java?0.00%?
    Values.java?95.65%?
    VerifyMutation.java?46.15%?
    View.java?96.82%?
    ViewChange.java?100.00%?
    ViewSnapshot.java?89.23%?
    WatchChange.java?70.51%?
    WatchChangeAggregator.java?98.21%?
    WatchStream.java?19.23%?
    Write.java?36.11%?
    WriteBatch.java?0.00%?
    WriteOrBuilder.java?0.00%?
    WriteProto.java?0.00%?
    WriteRequest.java?10.41%?
    WriteRequestOrBuilder.java?0.00%?
    WriteResponse.java?11.70%?
    WriteResponseOrBuilder.java?0.00%?
    WriteResult.java?0.00%?
    WriteResultOrBuilder.java?0.00%?
    WriteStream.java?31.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4RNSUtfxu9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 21, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (6071e9d)Merge (33dd98a)Diff
    aar1.32 MB1.32 MB-225 B (-0.0%)
    apk (release)3.93 MB3.93 MB-564 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8Q3NIx0Zkc.html

Base automatically changed from ehsann/in-expansion to master October 25, 2022 18:37
@ehsannas
Copy link
Contributor Author

As expected, the newly added tests currently fail against prod

wu-hui
wu-hui reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests to cover indexed queries as well?

@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Oct 25, 2022
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@ehsannas
Copy link
Contributor Author

Can we have some tests to cover indexed queries as well?

Do you mean the QueryTest integration test sets up an CSI similar to what's done in IndexingTest?

FWIW, I've added the equivalent unit tests for CSI side here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022 •
edited
Loading

Unit Test Results

     79 files   -    320       79 suites   - 320   1m 3s ⏱️ - 17m 11s
1 116 tests  - 3 639  1 100 ✔️  - 3 633  16 💤  - 5  0 ❌  - 1 
1 116 runs   - 3 655  1 100 ✔️  - 3 649  16 💤  - 5  0 ❌  - 1 

Results for commit 7f141d1. ± Comparison against base commit 6071e9d.

♻️ This comment has been updated with latest results.

@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Oct 26, 2022
wu-hui
wu-hui approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wu-hui wu-hui assigned ehsannas and wu-hui and unassigned wu-hui Oct 26, 2022
@ehsannas
Copy link
Contributor Author

Applying the "do not merge" label as relaxing these restrictions should not happen yet.

cherylEnkidu
cherylEnkidu reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last test in queriesInAndArrayContainsAnyArrayRules needs to be removed

@MarkDuckworth MarkDuckworth mentioned this pull request Nov 4, 2022
Closed
@ehsannas ehsannas requested a review from wu-hui January 30, 2023 20:42
@ehsannas
Copy link
Contributor Author

@wu-hui would you please review the last commit?

@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Jan 30, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile6071e9d33dd98aDiffSignificant (?)
    p10388 ±72 μs335 ±26 μs-52.9 μs (-13.6%)NO
    p25418 ±101 μs353 ±33 μs-64.9 μs (-15.5%)NO
    p50461 ±124 μs396 ±72 μs-65.2 μs (-14.1%)NO
    p75528 ±157 μs485 ±121 μs-42.9 μs (-8.1%)NO
    p90623 ±232 μs617 ±224 μs-5.88 μs (-0.9%)NO

    19 test runs in comparison
    CommitTest Runs
    6071e9d
    • 2023-02-15_22:00:42.092546_vSzt
    • 2023-02-15_22:00:42.095563_beNl
    • 2023-02-15_22:00:42.095579_sEUM
    • 2023-02-15_22:00:42.095586_MxIQ
    • 2023-02-15_22:00:42.095592_nhxu
    • 2023-02-15_22:00:42.095598_uYky
    • 2023-02-15_22:00:42.095604_AMxL
    • 2023-02-15_22:00:42.095614_tVyV
    • 2023-02-15_22:00:42.095621_xiiA
    33dd98a
    • 2023-02-15_22:22:06.967558_bdbh
    • 2023-02-15_22:22:06.968652_buTh
    • 2023-02-15_22:22:06.968664_Tzzl
    • 2023-02-15_22:22:06.968671_mrJQ
    • 2023-02-15_22:22:06.968678_YxoV
    • 2023-02-15_22:22:06.968688_kUJQ
    • 2023-02-15_22:22:06.968694_Xwyt
    • 2023-02-15_22:22:06.968700_LHAl
    • 2023-02-15_22:22:06.968706_bWin
    • 2023-02-15_22:22:06.968711_evXI
    redfin-30
    Percentile6071e9d33dd98aDiffSignificant (?)
    p10643 ±31 μs622 ±22 μs-21.3 μs (-3.3%)NO
    p25663 ±41 μs638 ±32 μs-25.2 μs (-3.8%)NO
    p50691 ±55 μs661 ±43 μs-29.6 μs (-4.3%)NO
    p75729 ±73 μs695 ±57 μs-34.6 μs (-4.7%)NO
    p90792 ±117 μs745 ±95 μs-47.8 μs (-6.0%)NO

    19 test runs in comparison
    CommitTest Runs
    6071e9d
    • 2023-02-15_22:00:42.092546_vSzt
    • 2023-02-15_22:00:42.095563_beNl
    • 2023-02-15_22:00:42.095579_sEUM
    • 2023-02-15_22:00:42.095586_MxIQ
    • 2023-02-15_22:00:42.095592_nhxu
    • 2023-02-15_22:00:42.095598_uYky
    • 2023-02-15_22:00:42.095604_AMxL
    • 2023-02-15_22:00:42.095614_tVyV
    • 2023-02-15_22:00:42.095621_xiiA
    33dd98a
    • 2023-02-15_22:22:06.967558_bdbh
    • 2023-02-15_22:22:06.968652_buTh
    • 2023-02-15_22:22:06.968664_Tzzl
    • 2023-02-15_22:22:06.968671_mrJQ
    • 2023-02-15_22:22:06.968678_YxoV
    • 2023-02-15_22:22:06.968688_kUJQ
    • 2023-02-15_22:22:06.968694_Xwyt
    • 2023-02-15_22:22:06.968700_LHAl
    • 2023-02-15_22:22:06.968706_bWin
    • 2023-02-15_22:22:06.968711_evXI

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile6071e9d33dd98aDiffSignificant (?)
    p10201 ±15 ms195 ±6 ms-5.70 ms (-2.8%)NO
    p25212 ±26 ms201 ±7 ms-10.9 ms (-5.2%)NO
    p50223 ±33 ms208 ±7 ms-14.7 ms (-6.6%)NO
    p75239 ±41 ms218 ±7 ms-20.4 ms (-8.5%)NO
    p90253 ±49 ms234 ±13 ms-19.3 ms (-7.6%)NO

    19 test runs in comparison
    CommitTest Runs
    6071e9d
    • 2023-02-15_22:00:42.092546_vSzt
    • 2023-02-15_22:00:42.095563_beNl
    • 2023-02-15_22:00:42.095579_sEUM
    • 2023-02-15_22:00:42.095586_MxIQ
    • 2023-02-15_22:00:42.095592_nhxu
    • 2023-02-15_22:00:42.095598_uYky
    • 2023-02-15_22:00:42.095604_AMxL
    • 2023-02-15_22:00:42.095614_tVyV
    • 2023-02-15_22:00:42.095621_xiiA
    33dd98a
    • 2023-02-15_22:22:06.967558_bdbh
    • 2023-02-15_22:22:06.968652_buTh
    • 2023-02-15_22:22:06.968664_Tzzl
    • 2023-02-15_22:22:06.968671_mrJQ
    • 2023-02-15_22:22:06.968678_YxoV
    • 2023-02-15_22:22:06.968688_kUJQ
    • 2023-02-15_22:22:06.968694_Xwyt
    • 2023-02-15_22:22:06.968700_LHAl
    • 2023-02-15_22:22:06.968706_bWin
    • 2023-02-15_22:22:06.968711_evXI
    redfin-30
    Percentile6071e9d33dd98aDiffSignificant (?)
    p10230 ±3 ms251 ±5 ms+21.5 ms (+9.4%)MAYBE
    p25235 ±3 ms257 ±4 ms+22.0 ms (+9.4%)YES
    p50242 ±3 ms264 ±4 ms+21.9 ms (+9.1%)YES
    p75249 ±4 ms273 ±5 ms+24.0 ms (+9.6%)YES
    p90257 ±3 ms285 ±6 ms+27.6 ms (+10.7%)YES

    19 test runs in comparison
    CommitTest Runs
    6071e9d
    • 2023-02-15_22:00:42.092546_vSzt
    • 2023-02-15_22:00:42.095563_beNl
    • 2023-02-15_22:00:42.095579_sEUM
    • 2023-02-15_22:00:42.095586_MxIQ
    • 2023-02-15_22:00:42.095592_nhxu
    • 2023-02-15_22:00:42.095598_uYky
    • 2023-02-15_22:00:42.095604_AMxL
    • 2023-02-15_22:00:42.095614_tVyV
    • 2023-02-15_22:00:42.095621_xiiA
    33dd98a
    • 2023-02-15_22:22:06.967558_bdbh
    • 2023-02-15_22:22:06.968652_buTh
    • 2023-02-15_22:22:06.968664_Tzzl
    • 2023-02-15_22:22:06.968671_mrJQ
    • 2023-02-15_22:22:06.968678_YxoV
    • 2023-02-15_22:22:06.968688_kUJQ
    • 2023-02-15_22:22:06.968694_Xwyt
    • 2023-02-15_22:22:06.968700_LHAl
    • 2023-02-15_22:22:06.968706_bWin
    • 2023-02-15_22:22:06.968711_evXI

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zVrOENYrVE/index.html

wu-hui
wu-hui approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ValidationTest.java Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@ehsannas ehsannas assigned MarkDuckworth and unassigned wu-hui Feb 15, 2023
MarkDuckworth
MarkDuckworth approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

firebase-firestore/src/main/java/com/google/firebase/firestore/core/Query.java Show resolved Hide resolved
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java Show resolved Hide resolved
@ehsannas ehsannas merged commit 5ea5bd0 into master Feb 15, 2023
@ehsannas ehsannas deleted the ehsann/in-expansion-2 branch February 15, 2023 23:30
@rlazo rlazo mentioned this pull request Feb 22, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu left review comments

@wu-hui wu-hui wu-hui approved these changes

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
main-merge-ack size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ehsannas @google-oss-bot @MarkDuckworth @wu-hui @cherylEnkidu