Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase logcat logging on release build #403

Closed
birfincankafein opened this issue May 3, 2019 · 5 comments
Closed

Firebase logcat logging on release build #403

birfincankafein opened this issue May 3, 2019 · 5 comments

Comments

@birfincankafein
Copy link

birfincankafein commented May 3, 2019

Environment

  • Android Studio version:

Android Studio 3.3
Build #AI-182.5107.16.33.5199772, built on December 25, 2018
JRE: 1.8.0_152-release-1248-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6

  • Firebase Component:
    FirebasePerformance, FirebaseRemoteConfig

  • Component versions:

com.google.firebase:firebase-core: 16.0.8
com.google.firebase:firebase-messaging: 17.4.0
com.google.firebase:firebase-config: 16.3.0
com.google.firebase:firebase-perf: 16.2.3

The problem

In my release build, I still can see the logs related to my configs, performance session ids, etc. It should not be logged to the console.

Relevant Code:

2019-05-03 14:35:37.064 6546-6546/? D/FirebasePerformance: Creating a new Non Verbose Session: XXXXX
2019-05-03 14:35:37.099 6546-6546/? D/FirebasePerformance: onResume(): XXXXX: 638220 microseconds
2019-05-03 14:35:38.168 6546-6569/? I/FirebaseRemoteConfig: Fetch succeeded!
2019-05-03 14:35:42.355 6546-6546/? W/FirebaseRemoteConfig: No value of type 'Boolean' exists for parameter key 'XXXXX'.
2019-05-03 14:35:42.359 6546-6546/? I/FirebasePerformance: Session ID - XXXXX
@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@ramanpreetSinghKhinda
Copy link
Contributor

Thnaks birfincankafein@ for reaching out.

1. D/FirebasePerformance: Creating a new Non Verbose Session: XXXXX

Session ID is an anonymous information which is solely for the debugging purposes, see:
https://firebase.google.com/docs/perf-mon/auto_duration-traces-metrics_ios-android#more-detail-trace-samples.

2. D/FirebasePerformance: onResume(): XXXXX: 638220 microseconds

We print the time it took for an activity to become visible, which is also for debugging purposes.


For the rest of the logs, assigning to RC to take a look

@clp93
Copy link
Contributor

clp93 commented Oct 21, 2019

I/FirebaseRemoteConfig: Fetch succeeded! Most Remote Config developers are generally interested in whether their Fetches are successful or not. As such, I'd consider this WAI. Firebase Performance uses Remote Config under the hood, so you'll get the Remote Config SDK info logs as part of the package.

W/FirebaseRemoteConfig: No value of type 'Boolean' exists for parameter key 'XXXXX'. is a warning that appears because of how Firebase Performance uses the Remote Config SDK. I'm going to assign this back to @ramanpreetSinghKhinda to see if his team can modify the way they call Remote Config to reduce those non-user relevant warnings.

@zijianjoy
Copy link

The fix has been submitted for stopping Firebase Performance logging by default. (To enable debug logging, follow document here https://firebase.google.com/docs/perf-mon/get-started-android#debug_your_integration)

Expect it to be available in upcoming Firebase Performance release (around mid January, 2020).

@zijianjoy zijianjoy added this to the M62 milestone Dec 23, 2019
@zijianjoy
Copy link

New Performance Monitoring version is released: https://firebase.google.com/support/release-notes/android#performance_v19-0-5.

@firebase firebase locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants