Increase number of retries before deleting events #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current retry logic will delete an event after 10 retries, which will only take ~17 minutes. If a device is on a bad network for that period of time, we could relatively easily lose events. Increasing this to 16 will extend this timeframe to ~18 hours, giving more opportunity for a retry to occur when the device has a better network connection.
rlazo
approved these changes
Jun 23, 2020
samedson
approved these changes
Jun 23, 2020
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (b63de82e) is created by Prow via merging commits: 08507fa f6dffed. |
Coverage ReportAffected SDKsNo changes between base commit (08507fa) and head commit (b63de82e). Test Logs
NotesHTML coverage reports can be produced locally with Head commit (b63de82e) is created by Prow via merging commits: 08507fa f6dffed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current retry logic will delete an event after 10 retries,
which will only take ~17 minutes for high priority events.
If a device is on a bad network for that period of time, we could
relatively easily lose these events.
Increasing this to 16 will extend this timeframe to ~18 hours,
giving more opportunity for a retry to occur when the device has
a better network connection.