-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANR at com.google.internal.firebase.inappmessaging.v1.sdkserving.InAppMessagingSdkServingGrpc$InAppMessagingSdkServingBlockingStub.fetchEligibleCampaigns (InAppMessagingSdkServingGrpc.java:222) #1430
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
@ashwinraghav Is this the bug that the FIS folks have been talking about when a user uses another SDK with FIS? messaging could cause that? |
I'm seeing this ANR in prod starting with update for
I get it for all my activities and for broadcast events: |
All my users who use a firewall (for example NetGuard) and block the internet for my application have this ANR too during the starting of the app. |
@evasua can you try following the instructions from the above ANR report and see if that fixes it for you. Specifically locking instance id to v20.0.2 or downgrading messaging to v20.1.0 |
Didn't check. I'm rolling out hotfix update with fiam rolled-back to |
Hey I think I understand what's happening here. Past 19.0.3 we changed to using a better async handling for our dependency on Firebase instance id. However this async work was unintentionally happening on the UI thread which means in the case where the network is down and the async work hangs we block the UI thread. This is my current working theory, I'm hoping to validate this and then have a fix ready asap |
Another quick update here. I am able to reproduce this issue using NetGuard. Fix coming soon |
@JasonAHeron Any ETA for the fix? ANRs have spiked extremely after upgrading to the latest Firebase SDKs. :( |
Hey, sorry a couple other fires to put out. I am dedicating all day today to this so hopefully I can get the fix ready by today or tomorrow. I can release this fix as a hotpatch so it will go out as soon as I can get it working and tested. From what I can see, the only way to repro is to disable network to the app using a VPN, have you folks reproduced this any other way? |
@JasonAHeron No, I unfortunately couldn't - however, looking at the rate of our ANRs I doubt that so many people are having their VPNs enabled. The spike even briefly made us cross Google Play's bad behavior threshold (which currently is at 0.47%) - so it is really affecting a lot of users out there. |
btw, reverting to |
Yes @stari4ek , reverting to 19.0.3 did solve the issue for me as well. |
@stari4ek Which other versions do you have ? For us we still have ANR problem with the current versions:
|
Here is all firebase deps I have:
I do not have direct dependency to |
Fix merged into master, I'll try to get a hotfix release out asap. |
Hey friends, we're going to be releasing this as a part of the official release coming tomorrow. So you should see fiam 19.0.6 available at that time. I'll leave this open and close it when the new dependency is available and verified. |
Any news here? We are desperately waiting fo the SDK update to release a fix for our app before the weekend to get it out of the bad behavior zone. |
Yep! We released 19.0.6 last night. I can leave this issue open until you verify that its fixed on your end. If I get no more responses here I'll close the issues in a few days because as far as I know it's fixed. |
@JasonAHeron Thanks a lot! 🤗 I checked https://firebase.google.com/support/release-notes/android#latest_sdk_versions and didn't see it there so I assumed that it's not live yet. I'll report back if the issue still persists. |
Yes, that is normally the place to go. I think the release notes are just delayed a bit but the artifacts are available so you should be able to update you dependency now. Release notes should be updated today |
@JasonAHeron things are looking good so far - no more ANRs so far. Seems this is fixed. 🙏 If it starts popping up again I'll post here in a few days after Play Console shows full statistics. |
Alright I'm closing this issue. |
[READ] Step 1: Are you in the right place?
Issues filed here should be about bugs in the code in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:
with the firebase tag.
google group.
of the above categories, reach out to the personalized
Firebase support channel.
[REQUIRED] Step 2: Describe your environment
[REQUIRED] Step 3: Describe the problem
Steps to reproduce:
This is shown as an ANR report.
The problem is happening only in one version after "Downgrade to SDKs that use a version of Firebase InstanceId before v20.1.0. The easiest way to do this is to depend on Firebase Messaging v20.1.0 (or before) and lock the version of Firebase InstanceId to v20.0.2 in your Gradle file." as suggested in #1339
These were the only changes:
classpath com.android.tools.build:gradle: 3.4.1 ->3.6.1
classpath io.fabric.tools:gradle: 1.28.1 -> 1.31.2
com.google.firebase:firebase-messaging: 20.1.3 -> 20.1.0
added explicit com.google.firebase:firebase-iid:20.0.2
implementation('com.crashlytics.sdk.android:crashlytics: 2.5.2 -> 2.10.1 ') {
transitive = true
}
Relevant Code:
The text was updated successfully, but these errors were encountered: