-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed Editor and ScrollView problems in iOS #26024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/rebase |
5e3b5bd to
551b5e9
Compare
Contributor
|
/rebase |
551b5e9 to
0149ac1
Compare
Contributor
|
/rebase |
0149ac1 to
d575f31
Compare
Contributor
|
/rebase |
Fixed Editor and ScrollView problems in iOS
modified snapshot for ios
Added platform-specific condition to skip the test case on Windows.
Reason updated for why test case fails on windows and Catalyst platform
d575f31 to
674b19e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-controls-editor
Editor
area-controls-scrollview
ScrollView
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
platform/ios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
Editor's width and height is not updated when changing the device orientation from landscape to portrait.
Root Cause:
When changing the device orientation from landscape to portrait, the Editor view retains its previous landscape bounds, as the bounds for the PlatformView of the Editor are not updated during the new layout pass from the parent. This issue occurs when the Editor is placed inside a nested ScrollView and Grid. The size of the grid (the presented content inside the first ScrollView) is not updated during the layout pass. As a result, the layout of subsequent children, such as the Border, second ScrollView, and the Editor itself, does not update correctly, causing the width and height to remain incorrect.
Description of Change:
I’ve called the scrollView.ArrangeContentUnbounded(Frame) method within the ArrangeOverride method of the ScrollView class. This ensures that the presented content (the Grid) updates its size, along with its child elements, including the Border, inner ScrollView, and Editor.
Tested the behavior in the following platforms.
Issues Fixed:
Fixes #22946
Screenshots