Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use license-maven-plugin Apache license 2.0 bundled header #3481

Draft
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

scordio
Copy link
Member

@scordio scordio commented May 20, 2024

Note

Waiting for the release of license-maven-plugin 4.6.

Relates to mathieucarbou/license-maven-plugin#532, fixes #3017.

@scordio scordio added this to the 3.27.0 milestone May 20, 2024
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@scordio scordio force-pushed the 3.x branch 2 times, most recently from 301ca01 to c730d18 Compare June 1, 2024 16:04
@scordio scordio force-pushed the gh-3017-apache-license branch 3 times, most recently from a0632a2 to 9e13822 Compare September 27, 2024 07:45
This also uses the Apache license 2.0 bundled header without email.
@scordio
Copy link
Member Author

scordio commented Sep 27, 2024

Spotless complains about the formatting of the new license headers:

@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,

It might make sense to look into the Spotless native support for license headers, thus removing the license-maven-plugin.

@scordio scordio modified the milestones: 3.27.0, 3.28.0 Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License header not in line with Apache license guidance
1 participant