pylibschc.rules: allow for Uncompressed Rule to be unset

anr-bmbf-pivot · Feb 15, 2023 · 7d2ba0e · 7d2ba0e
1 parent 9ab308b
commit 7d2ba0e
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/pylibschc/__init__.py b/pylibschc/__init__.py
@@ -9,4 +9,4 @@
 __copyright__ = "Copyright 2023 Freie Universität Berlin"
 __license__ = "GPLv3"
 __email__ = "[email protected]"
-__version__ = "0.0.1b0"
+__version__ = "0.0.1b1"
diff --git a/pylibschc/rules.py b/pylibschc/rules.py
@@ -485,7 +485,7 @@ class Device(BaseModel):
     duty_cycle: conint(ge=0x00000000, le=0xFFFFFFFF)
     """The duty cycle in milliseconds of the device. Must be 0
     < :attr:`Device.duty_cycle` ≤ :math:`(2^{32} - 1)`."""
-    uncompressed_rule: UncompressedRule
+    uncompressed_rule: UncompressedRule = None
     """The rule for an uncompressed packet on this device. Must not contain any
     duplicate rule IDs (i.e., same value of same bit width) with
     :attr:`Device.compression_rules` or :attr:`Device.fragmentation_rules`."""

diff --git a/tests/test_compressor.py b/tests/test_compressor.py
@@ -30,6 +30,20 @@ def reset_compressor_reassembler():
     pylibschc.compressor.CompressorDecompressor._inner = None
 
 
+def test_compressor_reassembler_no_uncompressed_rule(test_rules):
+    test_rules.devices[0].uncompressed_rule = None
+    config = test_rules.deploy()
+    device = config.devices[0]
+    direction = pylibschc.compressor.Direction.UP
+    cr = pylibschc.compressor.CompressorDecompressor(  # pylint: disable=invalid-name
+        device=device, direction=direction
+    )
+    bit_array = pylibschc.compressor.BitArray(bytes(IPv6()))
+    res, not_compressed = cr.output(bit_array)
+    assert res == pylibschc.compressor.CompressionResult.UNCOMPRESSED
+    assert bytes(IPv6()) == not_compressed.buffer
+
+
 @pytest.fixture()
 def exp_rules(request, test_rules):
     config = test_rules.deploy()

diff --git a/tests/test_rules.py b/tests/test_rules.py
@@ -998,6 +998,16 @@ def test_device_rule_id_duplicates():
         )
 
 
+def test_device_uncompressed_rule_none():
+    device = pylibschc.rules.Device(
+        device_id=1,
+        mtu=500,
+        duty_cycle=5000,
+        uncompressed_rule=None,
+    )
+    assert device.uncompressed_rule is None
+
+
 def test_device_c_schc_declaration():
     device = pylibschc.rules.Device(
         device_id=1,