-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DeltaEMethod a string #16
Comments
The two standard values should be "dE76" and "dE2000"; the first because it is fast, and may be good enough in some cases; and the latter because it is the most accurate method when that matters. |
Why prefix them all with |
Sure, if the method name already gives context it can be omitted |
OK so the two standard values would be "76" and "2000". |
After talking with @tabatkins again, we only need to make it a string if we want it to be user extensible. That said, are we still good with only |
As discussed with @tabatkins, to allow DeltaEMethod to be extensible, it should be a string instead of an enum, and the values can be checked via the implementation.
The text was updated successfully, but these errors were encountered: