Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules with external dependencies could specify a Docker container to test them #590

Open
JJ opened this issue Apr 13, 2021 · 2 comments
Open

Comments

@JJ
Copy link
Contributor

JJ commented Apr 13, 2021

Because if we're admitting into the ecosystem things that can't be tested, all bets are off. It's not difficult to ask some way of specifying a Docker container, maybe via the pull request itself.

@jonathanstowe
Copy link
Contributor

Well there could be an extension to the META format to specify an image name either in the support object or perhaps in a separate attribute, but I'd be worried that you'd spend all your time testing that rather than testing the module, also you'd end up re-inventing, say, "Github actions" as some of these things are going to be more than simply a docker container: a significant proportion of my modules, for example, install the external dependencies into the container as part of the test setup - otherwise you end up with a hulking great image. There are also those cases where the tests depend on an external service (say a DB server or something,) which may need configuring, starting etc. The complexity begins to stack up.

@JJ
Copy link
Contributor Author

JJ commented Apr 13, 2021

As a matter of fact, there's such a thing via the "from" field. Very few are using it, however. Also, there's no easy mapping from that to the actual package that can be installed. WRT to external services (as opposed to dependencies) I would strongly encourage people to mock them if they need to be installed... This is just ecosystem-inclusion testing, not production testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants