Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile name should be used instead of profile ID for block/unblock toast notifications #41

Open
ProfessionalMD5 opened this issue Jan 9, 2023 · 7 comments

Comments

@ProfessionalMD5
Copy link

Title says pretty much what I mean.

It is pretty hard to know who has blocked you when all we can see are profile ID numbers. I guess using the person's profile name would be better.

@ElJaviLuki
Copy link
Owner

Not everyone has a username on their profiles. This is just a quick workaround until we figure out something better.

@ProfessionalMD5
Copy link
Author

Not everyone has a username on their profiles. This is just a quick workaround until we figure out something better.

I guess it can be implied who the person is even when they don't have a name, but then maybe you could write something like "Unnamed profile" when the name string is blank.

@ProfessionalMD5
Copy link
Author

Not everyone has a username on their profiles. This is just a quick workaround until we figure out something better.

Do you know what is the variable for the profile name? I wanna build my own version that uses the name instead of the ID. Thanks in advance!

@secrj
Copy link

secrj commented Jan 20, 2023

Can we somehow save the messages so we make some sense who blocked us?

@ElJaviLuki
Copy link
Owner

Can we somehow save the messages so we make some sense who blocked us?

It could be possible. Now, what to implement? A database? A raw text file? When I have more time for this I'll try to go with it. I'm also interested on saving my blockers hehe.

You could make a pull request though ^^

@ProfessionalMD5
Copy link
Author

Can we somehow save the messages so we make some sense who blocked us?

It could be possible. Now, what to implement? A database? A raw text file? When I have more time for this I'll try to go with it. I'm also interested on saving my blockers hehe.

You could make a pull request though ^^

Wouldn't blocking the function that automatically deletes chats when user bans you be better?

@ElJaviLuki
Copy link
Owner

@ProfessionalMD5 It's not a bad solution but we want to know who's blocking us regardless of our chat history with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants