-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field adapters no longer work (v3.9.0) #666
Comments
In some wonkiness / fairness, in 3.8.0 Edit: also, as expected, writing an entirely new object to the field works. Writing the same object does not. Added more tests to the example. |
Haven't tested it but I'm now thinking this applies to hash fields (without any adapter) too? Anything that doesn't go through a dynamo |
I can confirm that my custom datatype also doesn't update on Version 3.9, but does on 3.8.
There is also no PUT call in the Console Output. and Lane looks like this
|
It looks like as an overlooked broken change. Thank you for the report. I suppose the expected behaviour is (at saving already persisted model) to persist all the attributes unconditionally if there is a field with custom type (field adapter), but not only changed/"dirty" attributes (like in works since 3.9.0) |
@andrykonchin Is this fixed in 3.10? |
No, it isn't fixed yet. |
I'm also seeing failure to update using |
@jufemaiz Could you please provide examples of code that don't work as expected to save an attribute new value with |
I'll work on an example that's not dependent on internal repos. |
This commit (per git bisect) 61c7f6b makes field adapters not longer work as expected, as changes to adapted fields are no saved in the dirty state.
Example of a failing test is in this PR #665. This PR passes on v3.8.0 and fails on v3.9.0.
git bisect
determined it was the commit above, which makes sense.tl;dr direct changes to any
field :foo, FooAdapter
are no longer persisted onsave!
The text was updated successfully, but these errors were encountered: