Skip to content

Mobile nav#55

Merged
jasondippel merged 6 commits intolaunchfrom
mobile-nav
Feb 5, 2021
Merged

Mobile nav#55
jasondippel merged 6 commits intolaunchfrom
mobile-nav

Conversation

@jasondippel
Copy link
Copy Markdown
Contributor

@jasondippel jasondippel commented Feb 5, 2021 •
edited
Loading

Reminder

Please ensure the following criteria is met for this PR. It will help others review your PR and provide confidence things work as expected.

  • CI is green
  • Link to any related issues
  • Received at least 1 approval from core members
  • Made sure that changes are obvious for the reviewer (ex meaningful title and commit messages, comments in code or PR where appropriate, screenshots, etc.)

What Changed?

Related Issue: Link

  • Made site nav change from hamburger menu to expanded links depending on screen size
  • Ensured focus can not get to rest of page when compact nav (overlay) is open

Screenshots

Kapture 2021-02-04 at 17 02 12

julie-huang
julie-huang approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@julie-huang julie-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after squashing :)

@jasondippel jasondippel merged commit eeef331 into launch Feb 5, 2021
@jasondippel jasondippel deleted the mobile-nav branch February 5, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superkhau superkhau Awaiting requested review from superkhau

@timothy-wan timothy-wan Awaiting requested review from timothy-wan

1 more reviewer

@julie-huang julie-huang julie-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasondippel @julie-huang