Skip to content

Conversation

@lsirac
Copy link
Contributor

@lsirac lsirac commented Sep 7, 2021

See go/workforce-pools-client-support.

@lsirac lsirac requested a review from a team as a code owner September 7, 2021 18:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@lsirac lsirac requested a review from TimurSadykov September 7, 2021 18:44
@TimurSadykov
Copy link

@lsirac unrelated to this feature, but I see there is a transportFactoryClassName that is never used. Is it expected?

@lsirac lsirac requested a review from TimurSadykov September 21, 2021 15:13
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on whether we need to expose those workforce pool methods?

@lsirac lsirac merged commit 5f3fed7 into googleapis:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants