Allow numericality :in to accept proc or symbol returning a Range #56445
+47
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
The
:inoption ofnumericalitycurrently only accepts a staticRange,while other numericality options such as
:greater_thanand:less_than_or_equal_toalready support procs and symbols.In practice, it is common for the valid range of a numeric attribute to depend
on other attributes of the same record. For example, a
Productmodel maydefine a minimum and maximum allowed price:
Validating that
pricefalls betweenmin_priceandmax_pricecurrentlyrequires a custom
validatemethod, even though the intent fits naturallywithin
numericality.Allowing
:into accept a proc or symbol that resolves to aRangeenablesthis use case to be expressed declaratively:
This change brings the
:inoption in line with other numericality options andwith validators such as
inclusionandexclusion, while remaining fullybackward compatible.