Fix html5 date types to support different locale (robotframework#1345)

aaltat · web-flow · commit 6ae07af6f0dc · 2019-03-19T23:42:57.000+02:00
Fixes robotframework#1344
diff --git a/.travis.yml b/.travis.yml
@@ -70,6 +70,7 @@ before_script:
   - if [ "$JYTHON" == "true" ]; then
       $INTERPRETER -m pip install mockito;
       $INTERPRETER -m pip install robotstatuschecker;
+      $INTERPRETER -m pip install python-dateutil;
       $INTERPRETER -m pip install -r requirements.txt;
     else
       $INTERPRETER -m pip install -r requirements-dev.txt;
diff --git a/atest/acceptance/keywords/textfields_html5.robot b/atest/acceptance/keywords/textfields_html5.robot
@@ -1,22 +1,27 @@
 *** Setting ***
 Test Setup        Go To Page "forms/html5_input_types.html"
 Resource          ../resource.robot
+Library           ../../resources/testlibs/date_parser.py
 
 *** Test Cases ***
 Input field type color
-    Input Text    id:color    \#72da19
+    Input Text    id:color     \#72da19
     ${value} =    Get Value    id:color
     Log    ${value}    # Get value does not return the changed value
 
 Input field type date
-    Input Text    id:date    03/01/2019
-    ${value} =    Get Value    id:date
-    Should Be Equal As Strings    ${value}    2019-03-01
+    ${date} =     Set Variable    11/22/2019
+    Input Text    id:date         ${date}
+    ${value} =    Get Value       id:date
+    ${date}    ${value} =    Parse Two Dates    ${date}    ${value}
+    Should Be Equal    ${value}    ${date}
 
 Input field type datetime-local
-    Input Text    id:datetime-local    12/24/201909:34AM
-    ${value} =    Get Value    id:datetime-local
-    Log    ${value}    # Get value does not return the value
+    ${date} =     Set Variable         04-03-002019 01:45PM
+    Input Text    id:datetime-local    ${date}
+    ${value} =    Get Value            id:datetime-local
+    ${date}    ${value} =    Parse Two Dates    ${date}    ${value}
+    Should Be Equal    ${value}    ${date}
 
 Input field type email
     Input Text    id:email    foo@bar.com
@@ -49,16 +54,18 @@ Input field type tel
     Should Be Equal As Strings    ${value}    123 456 567
 
 Input field type time
-    Input Text    id:time    02:34AM
+    ${time} =     Set Variable    02:34PM
+    Input Text    id:time         ${time}
     ${value} =    Get Value    id:time
-    Should Be Equal As Strings    ${value}    02:34
+    ${time}    ${value} =    Parse Two Dates    ${time}    ${value}
+    Should Be Equal    ${value}    ${time}
 
 Input field type url
     Input Text    id:url    https://github.com/robotframework/SeleniumLibrary
     ${value} =    Get Value    id:url
     Should Be Equal As Strings    ${value}    https://github.com/robotframework/SeleniumLibrary
 
 Input field type week
-    Input Text    id:week    012019
+    Input Text    id:week    452019
     ${value} =    Get Value    id:week
-    Should Be Equal As Strings    ${value}    2019-W01
+    Should Be Equal As Strings    ${value}    2019-W45
diff --git a/atest/resources/testlibs/date_parser.py b/atest/resources/testlibs/date_parser.py
@@ -0,0 +1,5 @@
+from dateutil.parser import parse
+
+
+def parse_two_dates(date1, date2):
+    return parse(date1), parse(date2)
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -4,6 +4,7 @@
 mockito >= 1.0.0
 robotstatuschecker
 approvaltests >= 0.2.4
+python-dateutil >= 2.8.0
 
 # Include normal dependencies from requirements.txt. Makes it possible to use
 # requirements-dev.txt as a single requirement file in PyCharm and other IDEs.
