Skip to content

WIP: new module: MultiQC_SAV #9587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matthdsm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: new module: MultiQC_SAV #9587

matthdsm wants to merge 1 commit into from

Conversation

@matthdsm
Copy link
Contributor

@matthdsm matthdsm commented Dec 18, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

maxulysse
maxulysse reviewed Dec 18, 2025
View reviewed changes
modules/nf-core/multiqc_sav/tests/nextflow.config
Copy link
Member

@maxulysse maxulysse Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Contributor Author

@matthdsm matthdsm Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I just copied it from the main MultiQC module

maxulysse
maxulysse reviewed Dec 18, 2025
View reviewed changes
modules/nf-core/multiqc_sav/main.nf
path "*.html" , emit: report
path "*_data" , emit: data
path "*_plots" , optional:true, emit: plots
tuple val("${task.process}"), val('multiqc'), eval('multiqc --version | sed "s/.* //g"'), val('multiqc_sav'), eval('python -c "import multiqc_sav; print(multiqc_sav.__version__)"'), emit: versions
Copy link
Member

@maxulysse maxulysse Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we capture the plugin version too?

Copy link
Contributor Author

@matthdsm matthdsm Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think that's important info, no?
Not sure if I did it the right way though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthdsm @maxulysse