Skip to content

Reapply: daemon/command: add support for sd_notify "reload" notifications#52041

Draft
vvoland wants to merge 3 commits intomoby:masterfrom
vvoland:unrevert-51965
Draft

Reapply: daemon/command: add support for sd_notify "reload" notifications#52041
vvoland wants to merge 3 commits intomoby:masterfrom
vvoland:unrevert-51965

Conversation

@vvoland
Copy link
Contributor

@vvoland vvoland commented Feb 13, 2026

Restoring for 29.3.0

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- Send sd_notify ["READY"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#READY=1) and ["STOPPING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#STOPPING=1) synchronously to make sure they are sent before we proceed.
- Add sd_notify ["RELOADING"](https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#RELOADING=1) notifications when signalling the daemon to reload its configuration.
- Add support for the systemd 253 `Type=notify-reload` service reload protocol.

- A picture of a cute animal (not mandatory but encouraged)

@vvoland vvoland self-assigned this Feb 13, 2026
@vvoland vvoland added this to the 29.3.0 milestone Feb 13, 2026
…synchronous"

This reverts commit c6ca7d4.

Signed-off-by: Paweł Gronowski <[email protected]>
…ions"

This reverts commit ddb636c.

Signed-off-by: Paweł Gronowski <[email protected]>
@thaJeztah thaJeztah added the release-blocker PRs we want to block a release on label Feb 13, 2026
@thaJeztah
Copy link
Member

Could we re-apply the original commits? Currently the commit message has (e.g.)

This reverts commit c6ca7d4.

Which takes you to the revert commit;

Revert "daemon/command: don't make notifyReady(), notifyStopping() asynchronous"

This reverts commit 236fc46.

Which .. finally brings you to the original commit, which has a much more descriptive commit message;

daemon/command: don't make notifyReady(), notifyStopping() asynchronous

Leave it to the consumer to decide whether these should be called in a
goroutine.

(just an example commit; the other commits have much more details in them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Core Engine platform/windows release-blocker PRs we want to block a release on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants