There are two cops involved:

• Layout/MultilineMethodCallIndentation which I think we should probably set to indented_relative_to_receiver
• Layout/IndentationWidth which I think we should apply as is

Good catch and agreed with the cop config choices. That said, I think we'll need to wait for 1.84.2 as there are errors occurring with the cops above. Thankfully fixes have already been merged to RuboCop master. Marking as draft until 1.84.2 is released.

RuboCop 1.84.1 (errors)

RuboCop head (no more errors)

v1.84.2 is out, rebasing and updating this PR.

https://github.com/rubocop/rubocop/releases/tag/v1.84.2

I don't feel strongly about this, but FWIW, the autocorrect changes here for that rule:

• Leave default of aligned - 23 corrections
• Change to indented - 86 corrections
• Change to indented_relative_to_receiver - 961 corrections

I have a small personal bias towards "indented" (which reduces overall PR alignment churn when you rename a var or method or something in the line above indentations) ... but mostly just wanted to show the file impact of each option there.

For stylistic reference here are the three different options. I feel indented is probably the most "default looking Ruby" as far as chaining .method calls is concerned but aligned and indented_relative_to_receiver both read a bit clearer as the calls are closer to the call above/receiver.

# app/controllers/api/v1/mutes_controller.rb#L19-L29
# aligned i.e. default
def paginated_mutes
  @paginated_mutes ||= Mute.eager_load(target_account: [:account_stat, :user])
                            .joins(:target_account)
                            .merge(Account.without_suspended)
                            .where(account: current_account)
                            .paginate_by_max_id(
                              limit_param(DEFAULT_ACCOUNTS_LIMIT),
                              params[:max_id],
                              params[:since_id]
                            )
end

# indented
def paginated_mutes
  @paginated_mutes ||= Mute.eager_load(target_account: [:account_stat, :user])
    .joins(:target_account)
    .merge(Account.without_suspended)
    .where(account: current_account)
    .paginate_by_max_id(
      limit_param(DEFAULT_ACCOUNTS_LIMIT),
      params[:max_id],
      params[:since_id]
    )
end

# indented_relative_to_receiver
def paginated_mutes
  @paginated_mutes ||= Mute.eager_load(target_account: [:account_stat, :user])
                          .joins(:target_account)
                          .merge(Account.without_suspended)
                          .where(account: current_account)
                          .paginate_by_max_id(
                            limit_param(DEFAULT_ACCOUNTS_LIMIT),
                            params[:max_id],
                            params[:since_id]
                          )
end

I think I prefer indented_relative_to_receiver stylistically but it's a good point regarding alignment churn.

oof, that's a lot of changes in either cases, and I'm surprised that so many of the issues would flare up in a patch release 🤔

I'm definitely fine with the Layout/IndentationWidth fixes but I'm honestly not quite sure how to proceed with Layout/MultilineMethodCallIndentation

oof, that's a lot of changes in either cases, and I'm surprised that so many of the issues would flare up in a patch release 🤔

Yeah, I suppose the cops causing these changes were really quite busted/not running in prior releases.

Looking at Layout/MultilineMethodCallIndentation, as pointed out by Matt above #37795 (comment) if we go with the indented we end up with both a reasonable number of changes and we will also avoid large indentation based diffs every time we rename something i.e. better/cleaner maintainability. Thus, for those reasons, I propose we go with indented for Layout/MultilineMethodCallIndentation.

Suppose I'm also a bit of a fan of indented as to me "next line, two spaces in" looks like idiomatic Ruby style.