fix nan-tw not listed in SUPPORTED_LOCALES#37721
Open
Yoxem wants to merge 4 commits intomastodon:mainfrom
Open
fix nan-tw not listed in SUPPORTED_LOCALES#37721Yoxem wants to merge 4 commits intomastodon:mainfrom
nan-tw not listed in SUPPORTED_LOCALES#37721Yoxem wants to merge 4 commits intomastodon:mainfrom
Conversation
Contributor
|
Hi! Thank you for your contribution! Your change would not actually add it to the available interface languages, I opened #37822 for that. Your change is still needed to add it to the supported posting languages, and seems overall ok, although I would avoid adding a hash just for one language. It seems to me this could fit into a |
Contributor
|
That being said, I'm no expert in language codes, and if you think |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though #34923 is merged, the
nan-tw(Taigi/Taiwanese Hokkien) is still not able to be chosen to be the interface language. I think that it's attributed to the lacking of ISO 639-3 (in the case,nan) is not in theISO_639_3list due to the lacking translation for the language (or language set). However, the ISO 639 code (Min Nan) is not translated, and because of the language separatism of Taigi and Taiwanese Nationalism, many Taigi-speaking people are opposed to using "Min Nan" (which means Southern Fujian Province of China) as the language they use, so I suggest to create another hash (like the dict data-structure in Python) namedNAN_TW_CODE, and append it to variableSUPPORTED_LOCALESand variableREGIONAL_LOCALE_NAMES.(cc @gunchleoc )