Skip to content

fix: Exclude domainEmitter from output#26

Merged
phated merged 1 commit intogulpjs:masterfrom
fasttime:fix-domainEmitter
Dec 6, 2022
Merged

fix: Exclude domainEmitter from output#26
phated merged 1 commit intogulpjs:masterfrom
fasttime:fix-domainEmitter

Conversation

@fasttime
Copy link
Copy Markdown
Contributor

@fasttime fasttime commented Dec 6, 2022

This excludes the property domainEmitter from the toString output.

References: #14, #25

Like domain and domainThrown, this property is only attached to errors that occur inside a domain, with domainEmitter holding a reference to the stream that emitted the error.

@fasttime fasttime marked this pull request as ready for review December 6, 2022 16:28
@phated phated changed the title fix!: Exclude domainEmitter from output fix: Exclude domainEmitter from output Dec 6, 2022
@phated
Copy link
Copy Markdown
Member

phated commented Dec 6, 2022

Thanks! I'm not going to call this breaking because it was missed in the original change.

@phated phated merged commit 2a89513 into gulpjs:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants