This repository was archived by the owner on Feb 26, 2026. It is now read-only.
fix: remove duplicate stream handler#106
Merged
daniel-sanche merged 2 commits intomasterfrom Dec 2, 2020
Merged
Conversation
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
daniel-sanche
added
the
type: bug
daniel-sanche
force-pushed
the
streamhandler
branch
from
a60d8c3 to
47daaa9
Compare
4 tasks
chetan
approved these changes
Nov 30, 2020
freelerobot
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extra StreamHandler. This was resulting in duplicate logs showing up on many GCP environments.
I tested this manually on our supported environments, and removing this doesn't have any negative impacts, and makes GKE and GAE standard much more usable
Fixes #38 🦕