This repository was archived by the owner on Mar 2, 2026. It is now read-only.
feat: pass 'client_options' to base class ctor#60
Merged
gcf-merge-on-green[bot] merged 2 commits intomasterfrom Aug 5, 2020
Merged
feat: pass 'client_options' to base class ctor#60gcf-merge-on-green[bot] merged 2 commits intomasterfrom
gcf-merge-on-green[bot] merged 2 commits intomasterfrom
Conversation
packaging: pin 'google-cloud-core >= 1.4.0' Closes #50.
google-cla
bot
added
the
cla: yes
chrisrossi
approved these changes
Aug 5, 2020
Contributor
chrisrossi
left a comment
chrisrossi
left a comment
There was a problem hiding this comment.
I'm finding it strange that google.cloud.datastore.client.Client was already accepting a client_options argument but wasn't doing anything with it. LGTM, other than confusion about the preceding state of the code.
tseaver
added
the
automerge
Contributor
Author
|
@chrisrossi If you look below the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packaging: pin 'google-cloud-core >= 1.4.0'
Closes #50.